Issue 9185013: Issue 965: Report error for static local function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9185013: Issue 965: Report error for static local function (Closed)

Created:
8 years, 11 months ago by scheglov

Modified:
8 years, 11 months ago

Reviewers:
zundel

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 965: Report error for static local function http://code.google.com/p/dart/issues/detail?id=965 R=zundel@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=3198

Patch Set 1 #

Total comments: 2

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -5 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	4 chunks	+6 lines, -2 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	2 chunks	+2 lines, -1 line	2 comments	Download
M	compiler/javatests/com/google/dart/compiler/CompilerTestCase.java	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/NegativeParserTest.java	View	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zundel

8 years, 11 months ago (2012-01-11 18:17:17 UTC) #2

lgtm with nit

http://codereview.chromium.org/9185013/diff/1/compiler/java/com/google/dart/c...
File compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java (right):

http://codereview.chromium.org/9185013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:64:
LOCAL_CANNOT_BE_STATIC("Local function may not be static"),
enum says "CANNOT" text says "may not"

http://codereview.chromium.org/9185013/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java:75:
TOP_LEVEL_CANNOT_BE_STATIC("Top-level field or method may not be static"),
same comment

Expand Messages | Collapse Messages