Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 918453002: Remove stray comment from ast.cc (Closed)

Created:
5 years, 10 months ago by adamk
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove stray comment from ast.cc This comment used to have a (commented-out) ASSERT attached to it. But that ASSERT was removed years ago, so the comment is now a non-sequitar. Committed: https://crrev.com/4043c45f463711d1b4d03e464088489039760b46 Cr-Commit-Position: refs/heads/master@{#26587}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/ast.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
adamk
Deletion of the assert was in crrev.com/44510671e908d0efc639513d81efcd81e7f14240
5 years, 10 months ago (2015-02-11 00:58:16 UTC) #2
arv (Not doing code reviews)
lgtm
5 years, 10 months ago (2015-02-11 15:13:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918453002/1
5 years, 10 months ago (2015-02-11 15:14:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 15:36:31 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 15:36:53 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4043c45f463711d1b4d03e464088489039760b46
Cr-Commit-Position: refs/heads/master@{#26587}

Powered by Google App Engine
This is Rietveld 408576698