Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 918443002: Make experimental app list use short names for app search results. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_uninstall_again
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make experimental app list use short names for app search results. This CL makes the app list search results use the short names of apps to be consistent with the name shown in the apps grid view. BUG=456961 Committed: https://crrev.com/7f03939abd247b3ba17d9a68901d43f184875750 Cr-Commit-Position: refs/heads/master@{#317006}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : always use short name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/app_list/search/app_search_provider.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
calamity
5 years, 10 months ago (2015-02-11 02:24:02 UTC) #3
Matt Giuca
https://codereview.chromium.org/918443002/diff/20001/chrome/browser/ui/app_list/search/app_search_provider.cc File chrome/browser/ui/app_list/search/app_search_provider.cc (right): https://codereview.chromium.org/918443002/diff/20001/chrome/browser/ui/app_list/search/app_search_provider.cc#newcode36 chrome/browser/ui/app_list/search/app_search_provider.cc:36: indexed_name_(base::UTF8ToUTF16(switches::IsExperimentalAppListEnabled() Ideally, this would not be gated on whether ...
5 years, 10 months ago (2015-02-12 02:17:48 UTC) #4
Matt Giuca
OK I asked the UX people on http://crbug.com/456961. We'll do this tomorrow (always use short ...
5 years, 10 months ago (2015-02-18 07:37:21 UTC) #5
Matt Giuca
OK you have your answer (go ahead and use short name everywhere).
5 years, 10 months ago (2015-02-19 00:27:52 UTC) #6
calamity
Done. Long names are dead, long live short names.
5 years, 10 months ago (2015-02-19 06:46:53 UTC) #7
Matt Giuca
lgtm
5 years, 10 months ago (2015-02-19 07:42:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918443002/40001
5 years, 10 months ago (2015-02-19 07:42:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-19 08:21:48 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 08:22:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f03939abd247b3ba17d9a68901d43f184875750
Cr-Commit-Position: refs/heads/master@{#317006}

Powered by Google App Engine
This is Rietveld 408576698