Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 918433002: Revert of PPAPI: Make tests that disable the proxy lock re-enable it (Closed)

Created:
5 years, 10 months ago by dmichael (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
teravest
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PPAPI: Make tests that disable the proxy lock re-enable it (patchset #2 id:20001 of https://codereview.chromium.org/908363002/) Reason for revert: Broke tests on Linux: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/9607 Original issue's description: > PPAPI: Make tests that disable the proxy lock re-enable it > > Rather than force all unit tests that rely on the ProxyLock to enable it, > let's make sure that all tests that _disable_ it re-enable it on exit. > > BUG= > R=teravest@chromium.org > > Committed: https://crrev.com/25ea5b2087b4c31fa42dea9b0de759d4895d0612 > Cr-Commit-Position: refs/heads/master@{#315666} TBR=teravest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a70de92b7f90d5e7b9e58a3ac87d800687d2c58e Cr-Commit-Position: refs/heads/master@{#315686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M content/renderer/pepper/pepper_file_chooser_host_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_url_request_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/proxy/raw_var_data_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/tracked_callback_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/var_tracker_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Created Revert of PPAPI: Make tests that disable the proxy lock re-enable it
5 years, 10 months ago (2015-02-11 00:22:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918433002/1
5 years, 10 months ago (2015-02-11 00:24:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 00:24:52 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 00:25:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a70de92b7f90d5e7b9e58a3ac87d800687d2c58e
Cr-Commit-Position: refs/heads/master@{#315686}

Powered by Google App Engine
This is Rietveld 408576698