Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 91843004: Fix scanning of regexp flags. (Closed)

Created:
7 years ago by ulan
Modified:
7 years ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Fix scanning of regexp flags. Set start and end positions of regex body and regex flags so that later literal construction produces correct result. BUG= R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18134

Patch Set 1 #

Patch Set 2 : Fix regex positions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/lexer/experimental-scanner.h View 1 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
7 years ago (2013-11-27 17:14:13 UTC) #1
marja
lgtm
7 years ago (2013-11-28 14:32:06 UTC) #2
ulan
7 years ago (2013-11-28 15:29:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18134 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698