Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 918403003: Remove courgette version tests. Add bsdiff version tests. (Closed)

Created:
5 years, 10 months ago by Will Harris
Modified:
5 years, 10 months ago
CC:
chromium-reviews, waffles
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove courgette version tests. Add bsdiff version tests. The component updater now only uses bsdiff so courgete diffs no longer have to forwards and backwards compatible, since Chrome always ships the correct version of the courgette patcher with the courgette diff. However, bsdiff generated diffs still have to be version compatible. This CL adds a test for the forwards compatible case. BUG=459505 Committed: https://crrev.com/23543f0d6b0b45854c447a1d5024add9e33a4150 Cr-Commit-Position: refs/heads/master@{#317117}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
A courgette/testdata/chrome64-1-2.v1.bsdiff View Binary file 0 comments Download
D courgette/testdata/chrome64-1-2.v1.patch View Binary file 0 comments Download
A courgette/testdata/setup1-setup2.v1.bsdiff View Binary file 0 comments Download
D courgette/testdata/setup1-setup2.v1.patch View Binary file 0 comments Download
M courgette/versioning_unittest.cc View 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Will Harris
5 years, 10 months ago (2015-02-18 06:44:08 UTC) #2
Will Harris
Ping dgarrett
5 years, 10 months ago (2015-02-19 09:07:29 UTC) #3
tommi (sloooow) - chröme
lgtm
5 years, 10 months ago (2015-02-19 19:00:34 UTC) #5
dgarrett
On 2015/02/19 19:00:34, tommi wrote: > lgtm lgtm to me as well.
5 years, 10 months ago (2015-02-19 19:02:03 UTC) #6
Will Harris
thanks +waffles for info now we see if the CQ can commit binaries.
5 years, 10 months ago (2015-02-19 19:27:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918403003/1
5 years, 10 months ago (2015-02-19 19:29:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 20:03:43 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 20:05:03 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/23543f0d6b0b45854c447a1d5024add9e33a4150
Cr-Commit-Position: refs/heads/master@{#317117}

Powered by Google App Engine
This is Rietveld 408576698