Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1438)

Unified Diff: pkg/analysis_server/lib/src/get_handler.dart

Issue 918383002: Rework analysis server performance measurement code. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/get_handler.dart
diff --git a/pkg/analysis_server/lib/src/get_handler.dart b/pkg/analysis_server/lib/src/get_handler.dart
index 2dadde0826c5a67764faca740712d855160c1b19..c424eaa965dc587d61973217cdddeafa9aa9afea 100644
--- a/pkg/analysis_server/lib/src/get_handler.dart
+++ b/pkg/analysis_server/lib/src/get_handler.dart
@@ -267,8 +267,8 @@ class GetHandler {
'Analysis Server - Analysis Performance',
[],
(StringBuffer buffer) {
- void writeRow(TimeCounter counter, String label) {
- _writeRow(buffer, [counter.result, label], classes: ["right", null]);
+ void writeRow(PerformanceTag tag) {
+ _writeRow(buffer, [tag.elapsedMs, tag.label], classes: ["right", null]);
}
buffer.write('<h3>Analysis Performance</h3>');
@@ -276,13 +276,7 @@ class GetHandler {
buffer.write(
'<table style="border-collapse: separate; border-spacing: 10px 5px;">');
_writeRow(buffer, ['Time (in ms)', 'Analysis Phase'], header: true);
- writeRow(PerformanceStatistics.io, 'io');
- writeRow(PerformanceStatistics.scan, 'scan');
- writeRow(PerformanceStatistics.parse, 'parse');
- writeRow(PerformanceStatistics.resolve, 'resolve');
- writeRow(PerformanceStatistics.errors, 'errors');
- writeRow(PerformanceStatistics.hints, 'hints');
- writeRow(PerformanceStatistics.lint, 'lint');
+ PerformanceTag.all.forEach(writeRow);
buffer.write('</table>');
Map<DataDescriptor, Map<CacheState, int>> transitionMap = SourceEntry.transitionMap;
« no previous file with comments | « pkg/analysis_server/lib/src/analysis_server.dart ('k') | pkg/analysis_server/lib/src/operation/operation_analysis.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698