Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: src/globals.h

Issue 918373002: Strip Interface class of most of its logic, make it all about Module exports (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Merged to trunk Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen.cc ('k') | src/hydrogen.cc » ('j') | src/interface.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index 0edd643796e0d6bd5d3c0324e24fa7745a998c9a..8c77751351d2d74ee7323e23b0781170c1b74cd4 100644
--- a/src/globals.h
+++ b/src/globals.h
@@ -712,12 +712,10 @@ enum VariableMode {
CONST_LEGACY, // declared via legacy 'const' declarations
- LET, // declared via 'let' declarations (first lexical)
+ LET, // declared via 'let' declarations
CONST, // declared via 'const' declarations
- MODULE, // declared via 'module' declaration (last lexical)
-
// Variables introduced by the compiler:
INTERNAL, // like VAR, but not user-visible (may or may not
// be in a context)
@@ -745,17 +743,17 @@ inline bool IsDynamicVariableMode(VariableMode mode) {
inline bool IsDeclaredVariableMode(VariableMode mode) {
- return mode >= VAR && mode <= MODULE;
+ return mode >= VAR && mode <= CONST;
}
inline bool IsLexicalVariableMode(VariableMode mode) {
- return mode >= LET && mode <= MODULE;
+ return mode == LET || mode == CONST;
}
inline bool IsImmutableVariableMode(VariableMode mode) {
- return (mode >= CONST && mode <= MODULE) || mode == CONST_LEGACY;
+ return (mode >= CONST && mode <= CONST) || mode == CONST_LEGACY;
rossberg 2015/02/16 12:46:43 mode == CONST ;)
adamk 2015/02/17 19:59:34 Ha! I'd made this change in a bunch of different b
}
« no previous file with comments | « src/full-codegen.cc ('k') | src/hydrogen.cc » ('j') | src/interface.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698