Strip Interface class of most of its logic, make it all about Module exports

src/full-codegen.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/ast.h"
 #include "src/ast-numbering.h"
 #include "src/code-factory.h"
 #include "src/codegen.h"
@@ skipping 42 matching lines @@
 
 void BreakableStatementChecker::VisitExportDeclaration(
     ExportDeclaration* decl) {
 }
 
 
 void BreakableStatementChecker::VisitModuleLiteral(ModuleLiteral* module) {
 }
 
 
-void BreakableStatementChecker::VisitModuleVariable(ModuleVariable* module) {
-}
-
-
 void BreakableStatementChecker::VisitModulePath(ModulePath* module) {
 }
 
 
 void BreakableStatementChecker::VisitModuleUrl(ModuleUrl* module) {
 }
 
 
 void BreakableStatementChecker::VisitModuleStatement(ModuleStatement* stmt) {
 }
@@ skipping 531 matching lines @@
   DCHECK(scope_->is_script_scope());
 
   for (int i = 0; i < declarations->length(); i++) {
     ModuleDeclaration* declaration = declarations->at(i)->AsModuleDeclaration();
     if (declaration != NULL) {
       ModuleLiteral* module = declaration->module()->AsModuleLiteral();
       if (module != NULL) {
         Comment cmnt(masm_, "[ Link nested modules");
         Scope* scope = module->body()->scope();
         Interface* interface = scope->interface();
-        DCHECK(interface->IsModule() && interface->IsFrozen());
+        DCHECK(interface->IsFrozen());
 
         interface->Allocate(scope->module_var()->index());
 
         // Set up module context.
         DCHECK(scope->interface()->Index() >= 0);
         __ Push(Smi::FromInt(scope->interface()->Index()));
         __ Push(scope->GetScopeInfo(isolate()));
         __ CallRuntime(Runtime::kPushModuleContext, 2);
         StoreToFrameField(StandardFrameConstants::kContextOffset,
                           context_register());
@@ skipping 153 matching lines @@
   modules_->set(index, *description);
 
   scope_ = saved_scope;
   // Pop module context.
   LoadContextField(context_register(), Context::PREVIOUS_INDEX);
   // Update local stack frame context field.
   StoreToFrameField(StandardFrameConstants::kContextOffset, context_register());
 }
 
 
-void FullCodeGenerator::VisitModuleVariable(ModuleVariable* module) {
-  // Nothing to do.
-  // The instance object is resolved statically through the module's interface.
-}
-
-
 void FullCodeGenerator::VisitModulePath(ModulePath* module) {
   // Nothing to do.
   // The instance object is resolved statically through the module's interface.
 }
 
 
 void FullCodeGenerator::VisitModuleUrl(ModuleUrl* module) {
   // TODO(rossberg): dummy allocation for now.
   Scope* scope = module->body()->scope();
   Interface* interface = scope_->interface();
 
-  DCHECK(interface->IsModule() && interface->IsFrozen());
+  DCHECK(interface->IsFrozen());
   DCHECK(!modules_.is_null());
   DCHECK(module_index_ < modules_->length());
   interface->Allocate(scope->module_var()->index());
   int index = module_index_++;
 
   Handle<ModuleInfo> description =
       ModuleInfo::Create(isolate(), interface, scope_);
   modules_->set(index, *description);
 }
 
@@ skipping 276 matching lines @@
         this, stmt->scope(), stmt->EntryId(), stmt->DeclsId(), stmt->ExitId());
     VisitStatements(stmt->statements());
     __ bind(nested_block.break_label());
   }
 }
 
 
 void FullCodeGenerator::VisitModuleStatement(ModuleStatement* stmt) {
   Comment cmnt(masm_, "[ Module context");
 
-  __ Push(Smi::FromInt(stmt->proxy()->interface()->Index()));
+  DCHECK(stmt->body()->scope()->is_module_scope());
+
+  __ Push(Smi::FromInt(stmt->body()->scope()->interface()->Index()));
   __ Push(Smi::FromInt(0));
   __ CallRuntime(Runtime::kPushModuleContext, 2);
   StoreToFrameField(
       StandardFrameConstants::kContextOffset, context_register());
 
   Scope* saved_scope = scope_;
   scope_ = stmt->body()->scope();
   VisitStatements(stmt->body()->statements());
   scope_ = saved_scope;
   LoadContextField(context_register(), Context::PREVIOUS_INDEX);
@@ skipping 728 matching lines @@
   }
   codegen_->PrepareForBailoutForId(exit_id_, NO_REGISTERS);
   codegen_->scope_ = saved_scope_;
 }
 
 
 #undef __
 
 
 } }  // namespace v8::internal