Add the c++ code part of bindings2/

sky/engine/bindings2/builtin_natives.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "sky/engine/config.h"
+#include "sky/engine/bindings2/builtin_natives.h"
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include "base/bind.h"
+#include "base/logging.h"
+#include "base/macros.h"
+#include "dart/runtime/include/dart_api.h"
+#include "sky/engine/bindings2/builtin.h"
+#include "sky/engine/core/dom/Microtask.h"
+#include "sky/engine/core/script/dom_dart_state.h"
+#include "sky/engine/tonic/dart_api_scope.h"
+#include "sky/engine/tonic/dart_error.h"
+#include "sky/engine/tonic/dart_isolate_scope.h"
+#include "sky/engine/tonic/dart_state.h"
+#include "sky/engine/tonic/dart_value.h"
+#include "sky/engine/wtf/text/WTFString.h"
+
+namespace blink {
+
+#define REGISTER_FUNCTION(name, count)                                         \
+  { "" #name, name, count },
+#define DECLARE_FUNCTION(name, count)                                          \
+  extern void name(Dart_NativeArguments args);
+
+// Lists the native functions implementing basic functionality in
+// the Mojo embedder dart, such as printing, and file I/O.
+#define BUILTIN_NATIVE_LIST(V) \
+  V(Logger_PrintString, 1)     \
+  V(ScheduleMicrotask, 1)      \
+  V(Timer_create, 3)           \
+  V(Timer_cancel, 1)
+
+BUILTIN_NATIVE_LIST(DECLARE_FUNCTION);
+
+static struct NativeEntries {
+  const char* name;
+  Dart_NativeFunction function;
+  int argument_count;
+} BuiltinEntries[] = {BUILTIN_NATIVE_LIST(REGISTER_FUNCTION)};
+
+Dart_NativeFunction BuiltinNatives::NativeLookup(Dart_Handle name,
+                                                 int argument_count,
+                                                 bool* auto_setup_scope) {
+  const char* function_name = nullptr;
+  Dart_Handle result = Dart_StringToCString(name, &function_name);
+  DART_CHECK_VALID(result);
+  DCHECK(function_name != nullptr);
+  DCHECK(auto_setup_scope != nullptr);
+  *auto_setup_scope = true;
+  size_t num_entries = arraysize(BuiltinEntries);
+  for (size_t i = 0; i < num_entries; i++) {

[eseidel, 2015/02/12 21:09:37]

I wonder if this is wroth having has an array or if a hashtable would be simpler
(and not slower enough to matter).

+    const struct NativeEntries& entry = BuiltinEntries[i];
+    if (!strcmp(function_name, entry.name) &&
+        (entry.argument_count == argument_count)) {
+      return entry.function;
+    }
+  }
+  return nullptr;
+}
+
+const uint8_t* BuiltinNatives::NativeSymbol(Dart_NativeFunction native_function) {
+  size_t num_entries = arraysize(BuiltinEntries);
+  for (size_t i = 0; i < num_entries; i++) {
+    const struct NativeEntries& entry = BuiltinEntries[i];
+    if (entry.function == native_function) {
+      return reinterpret_cast<const uint8_t*>(entry.name);
+    }
+  }
+  return nullptr;
+}
+
+static Dart_Handle GetClosure(Dart_Handle builtin_library, const char* name) {
+  Dart_Handle getter_name = Dart_NewStringFromCString(name);
+  Dart_Handle closure = Dart_Invoke(builtin_library, getter_name, 0, nullptr);
+  DART_CHECK_VALID(closure);
+  return closure;
+}
+
+static void InitDartInternal(Dart_Handle builtin_library) {
+  Dart_Handle print = GetClosure(builtin_library, "_getPrintClosure");
+  Dart_Handle timer = GetClosure(builtin_library, "_getCreateTimerClosure");
+
+  Dart_Handle internal_name = Dart_NewStringFromCString("dart:_internal");

[eseidel, 2015/02/12 21:09:37]

We should have a helper.  Dart_Handle LookupLibrary(char*) which does these 3
lines.

[abarth-chromium, 2015/02/12 21:17:54]

We should just add DartConverter<char*>.  Then you can use ToDart("...")

+  Dart_Handle internal_library = Dart_LookupLibrary(internal_name);
+  DART_CHECK_VALID(internal_library);
+
+  DART_CHECK_VALID(Dart_SetField(
+      internal_library, Dart_NewStringFromCString("_printClosure"), print));
+
+  Dart_Handle vm_hooks_name = Dart_NewStringFromCString("VMLibraryHooks");
+  Dart_Handle vm_hooks = Dart_GetClass(internal_library, vm_hooks_name);
+  DART_CHECK_VALID(vm_hooks);
+  Dart_Handle timer_name = Dart_NewStringFromCString("timerFactory");

[eseidel, 2015/02/12 21:09:37]

We should consider a dartString(char*) helper.  Possibly one which handles
atomizing/caching.

+  DART_CHECK_VALID(Dart_SetField(vm_hooks, timer_name, timer));
+}
+
+static void InitAsync(Dart_Handle builtin_library) {
+  Dart_Handle schedule_microtask =
+      GetClosure(builtin_library, "_getScheduleMicrotaskClosure");
+  Dart_Handle async_name = Dart_NewStringFromCString("dart:async");
+  Dart_Handle async_library = Dart_LookupLibrary(async_name);
+  DART_CHECK_VALID(async_library);
+  Dart_Handle set_schedule_microtask =
+      Dart_NewStringFromCString("_setScheduleImmediateClosure");
+  DART_CHECK_VALID(Dart_Invoke(async_library, set_schedule_microtask, 1,
+                               &schedule_microtask));
+}
+
+void BuiltinNatives::Init() {
+  Dart_Handle builtin = Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);
+  DART_CHECK_VALID(builtin);
+  InitDartInternal(builtin);
+  InitAsync(builtin);
+}
+
+// Implementation of native functions which are used for some
+// test/debug functionality in standalone dart mode.
+void Logger_PrintString(Dart_NativeArguments args) {
+  intptr_t length = 0;
+  uint8_t* chars = nullptr;
+  Dart_Handle str = Dart_GetNativeArgument(args, 0);
+  Dart_Handle result = Dart_StringToUTF8(str, &chars, &length);
+  if (Dart_IsError(result)) {
+    Dart_PropagateError(result);
+  } else {
+
+  String message(chars, length);
+// TODO(dart): Hook up to developer console (if/when that's a thing).

[abarth-chromium, 2015/02/12 20:52:31]

This comment should be indented two spaces

+#if OS(ANDROID)
+    LOG(INFO) << "CONSOLE: " << message.utf8().data();
+#else
+    printf("CONSOLE: %s\n", message.utf8().data());
+#endif
+
+  }
+  fflush(stdout);

[eseidel, 2015/02/12 21:09:37]

I think this only makes sense in the printf case, or?  Does log(INFO) always go
to out?

[abarth-chromium, 2015/02/12 21:17:54]

Yeah, this should be in the printf branch.

+}
+
+static void ExecuteMicrotask(base::WeakPtr<DartState> dart_state,
+                             RefPtr<DartValue> callback) {
+  if (!dart_state)
+    return;
+  DartIsolateScope scope(dart_state->isolate());
+  DartApiScope api_scope;
+  LogIfError(Dart_InvokeClosure(callback->dart_value(), 0, nullptr));
+}
+
+void ScheduleMicrotask(Dart_NativeArguments args) {
+  DartState* dart_state = DartState::Current();

[eseidel, 2015/02/12 21:09:37]

Do we need/want to get the state before checking the closure?

[abarth-chromium, 2015/02/12 21:17:54]

No.  It should move down.

+  Dart_Handle closure = Dart_GetNativeArgument(args, 0);
+  if (LogIfError(closure) || !Dart_IsClosure(closure))
+    return;
+  Microtask::enqueueMicrotask(base::Bind(&ExecuteMicrotask,
+    dart_state->GetWeakPtr(), DartValue::Create(dart_state, closure)));
+}
+
+void Timer_create(Dart_NativeArguments args) {
+  int64_t milliseconds = 0;
+  DART_CHECK_VALID(Dart_GetNativeIntegerArgument(args, 0, &milliseconds));
+  Dart_Handle closure = Dart_GetNativeArgument(args, 1);
+  DART_CHECK_VALID(closure);
+  CHECK(Dart_IsClosure(closure));
+  bool repeating = false;
+  DART_CHECK_VALID(Dart_GetNativeBooleanArgument(args, 2, &repeating));
+
+  DOMDartState* state = DOMDartState::Current();
+  int timer_id = DOMTimer::install(state->document(),
+                                   ScheduledAction::Create(state, closure),
+                                   milliseconds,
+                                   !repeating);
+  Dart_SetIntegerReturnValue(args, timer_id);
+}
+
+void Timer_cancel(Dart_NativeArguments args) {
+  int64_t timer_id = 0;
+  DART_CHECK_VALID(Dart_GetNativeIntegerArgument(args, 0, &timer_id));
+
+  DOMDartState* state = DOMDartState::Current();
+  DOMTimer::removeByID(state->document(), timer_id);
+}
+
+}  // namespace blink