Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 91833002: Experimental scanner: keeping track of octal numbers octal escapes. (Closed)

Created:
7 years ago by marja
Modified:
7 years ago
Reviewers:
dcarney, ulan
CC:
v8-dev
Visibility:
Public.

Description

Experimental scanner: keeping track of octal numbers and octal escapes. The baseline uses a more liberal definition than ECMA, but it's ok, since this is only used for whining about octal escapes in the strict mode. (So, even though "\1" is technically not an octal escape inside a string (since it should be exactly 2 digits), it's still a good idea to whine. R=dcarney@chromium.org TBR=dcarney@chromium.org, ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18110

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -60 lines) Patch
src/lexer/experimental-scanner.h View 9 chunks +29 lines, -18 lines 0 comments Download
src/lexer/lexer-shell.cc View 3 chunks +16 lines, -5 lines 0 comments Download
src/lexer/lexer_py.re View 4 chunks +8 lines, -2 lines 0 comments Download
test/lexer/cornercases/octals.js View 1 chunk +31 lines, -33 lines 0 comments Download
test/lexer/cornercases/strings-and-identifiers-with-escapes.js View 1 chunk +6 lines, -1 line 0 comments Download
tools/lexer_generator/code_generator.jinja View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
lgtm
7 years ago (2013-11-27 15:25:42 UTC) #1
marja
Committed patchset #1 manually as r18110 (presubmit successful).
7 years ago (2013-11-27 15:28:56 UTC) #2
ulan
7 years ago (2013-11-27 15:28:57 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698