Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 918313003: Reset drag_image_ in web_test_proxy. (Closed)

Created:
5 years, 10 months ago by jackhou1
Modified:
5 years, 10 months ago
Reviewers:
tkent
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset drag_image_ in web_test_proxy. I forgot this in an earlier CL: https://codereview.chromium.org/904833004/ It needs to be reset so that WebTestProxy is in a clean state for subsequent tests. BUG=458077

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/shell/renderer/test_runner/web_test_proxy.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jackhou1
tkent, could you please take a look?
5 years, 10 months ago (2015-02-13 00:13:18 UTC) #2
tkent
lgtm
5 years, 10 months ago (2015-02-13 01:26:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918313003/1
5 years, 10 months ago (2015-02-13 01:27:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/46485)
5 years, 10 months ago (2015-02-13 02:00:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918313003/1
5 years, 10 months ago (2015-02-13 02:02:43 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/46503)
5 years, 10 months ago (2015-02-13 02:29:07 UTC) #11
tkent
Hmm, this doesn't pass CQ. Let me stop CQ for this, and revert https://codereview.chromium.org/904833004/ .
5 years, 10 months ago (2015-02-13 02:30:09 UTC) #12
jackhou1
5 years, 10 months ago (2015-02-13 04:54:19 UTC) #13
Message was sent while issue was closed.
On 2015/02/13 02:30:09, tkent wrote:
> Hmm, this doesn't pass CQ.  Let me stop CQ for this, and revert
> https://codereview.chromium.org/904833004/ .

Changes merged into https://codereview.chromium.org/916893003/

Powered by Google App Engine
This is Rietveld 408576698