Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 918263003: Actually stop Sky from linking with V8 (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Actually stop Sky from linking with V8 We don't use V8 anymore. There's no reason to link it in. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1b39c98d8ceec33768731784e909bda0bc0b9d10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M sky/engine/bindings/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-13 04:36:56 UTC) #1
abarth-chromium
5 years, 10 months ago (2015-02-13 05:18:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b39c98d8ceec33768731784e909bda0bc0b9d10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698