Issue 918263003: Actually stop Sky from linking with V8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 918263003: Actually stop Sky from linking with V8 (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Actually stop Sky from linking with V8 We don't use V8 anymore. There's no reason to link it in. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1b39c98d8ceec33768731784e909bda0bc0b9d10

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -4 lines)			Patch
M	sky/engine/bindings/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/html/HTMLIFrameElement.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/viewer/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 10 months ago (2015-02-13 05:18:53 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1b39c98d8ceec33768731784e909bda0bc0b9d10 (presubmit successful).