Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 918213004: Force chromium_ios_signing=0 on iOS bots (Closed)

Created:
5 years, 10 months ago by smut
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Force chromium_ios_signing=0 on iOS bots Because there is no signing identity on upstream bots. Omitting this variable is causing at least device bots to assume it should be 1, might as well be explicit on all bots. BUG=452193 Committed: https://crrev.com/c98c98661a9a739e357d0fa4ea5756effcfbb132 Cr-Commit-Position: refs/heads/master@{#316215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ios/build/bots/chromium.fyi/Chromium_iOS_Device.json View 1 chunk +1 line, -0 lines 0 comments Download
M ios/build/bots/chromium.fyi/Chromium_iOS_Device_(ninja).json View 1 chunk +1 line, -0 lines 0 comments Download
M ios/build/bots/chromium.fyi/Chromium_iOS_Simulator_(dbg).json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
smut
5 years, 10 months ago (2015-02-12 21:15:45 UTC) #2
ghost stip (do not use)
lgtm, please get Lane's approval before committing
5 years, 10 months ago (2015-02-12 23:11:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918213004/1
5 years, 10 months ago (2015-02-13 14:46:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 15:05:52 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 15:06:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c98c98661a9a739e357d0fa4ea5756effcfbb132
Cr-Commit-Position: refs/heads/master@{#316215}

Powered by Google App Engine
This is Rietveld 408576698