Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Issue 918213002: Protect access to the external_snapshot_blob global with a lock. (Closed)

Created:
5 years, 10 months ago by rmcilroy
Modified:
5 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Protect access to the external_snapshot_blob global with a lock. The external_snapshot_blob is a global and might be accessed from multiple threads. Protect it with a lock. BUG=457656 LOG=N R=vogelheim@chromium.org Committed: https://crrev.com/1da1e34788eca083eec26492e16da76f8520eee4 Cr-Commit-Position: refs/heads/master@{#26638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/snapshot-external.cc View 3 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
rmcilroy
PTAL, thanks.
5 years, 10 months ago (2015-02-12 15:52:31 UTC) #2
vogelheim
lgtm
5 years, 10 months ago (2015-02-12 17:49:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918213002/1
5 years, 10 months ago (2015-02-12 17:56:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2951)
5 years, 10 months ago (2015-02-12 18:02:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918213002/1
5 years, 10 months ago (2015-02-13 07:59:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2973)
5 years, 10 months ago (2015-02-13 08:05:37 UTC) #11
rmcilroy
Committed patchset #1 (id:1) manually as 1da1e34788eca083eec26492e16da76f8520eee4 (presubmit successful).
5 years, 10 months ago (2015-02-13 10:36:03 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 10:36:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1da1e34788eca083eec26492e16da76f8520eee4
Cr-Commit-Position: refs/heads/master@{#26638}

Powered by Google App Engine
This is Rietveld 408576698