Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1253)

Unified Diff: src/parser.h

Issue 918203002: Get rid of PreParserIdentifier. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: . Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast-value-factory.h ('k') | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parser.h
diff --git a/src/parser.h b/src/parser.h
index c1b0361980d23bdc4c3de4bf2134210e4940abcf..4fd832e978f3866c5e11daeed8f751ac0707d5af 100644
--- a/src/parser.h
+++ b/src/parser.h
@@ -364,7 +364,6 @@ class ParserTraits {
typedef Vector<VariableProxy*> ParameterIdentifierVector;
// Return types for traversing functions.
- typedef const AstRawString* Identifier;
typedef v8::internal::Expression* Expression;
typedef Yield* YieldExpression;
typedef v8::internal::FunctionLiteral* FunctionLiteral;
@@ -382,8 +381,6 @@ class ParserTraits {
explicit ParserTraits(Parser* parser) : parser_(parser) {}
// Helper functions for recursive descent.
- bool IsEvalOrArguments(const AstRawString* identifier) const;
- V8_INLINE bool IsFutureStrictReserved(const AstRawString* identifier) const;
// Returns true if the expression is of type "this.foo".
static bool IsThisProperty(Expression* expression);
@@ -403,10 +400,6 @@ class ParserTraits {
return ObjectLiteral::IsBoilerplateProperty(property);
}
- static bool IsArrayIndex(const AstRawString* string, uint32_t* index) {
- return string->AsArrayIndex(index);
- }
-
static Expression* GetPropertyValue(ObjectLiteral::Property* property) {
return property->value();
}
@@ -505,9 +498,6 @@ class ParserTraits {
bool is_reference_error = false);
// "null" return type creators.
- static const AstRawString* EmptyIdentifier() {
- return NULL;
- }
static Expression* EmptyExpression() {
return NULL;
}
@@ -523,17 +513,10 @@ class ParserTraits {
return NULL;
}
- // Non-NULL empty string.
- V8_INLINE const AstRawString* EmptyIdentifierString();
-
// Odd-ball literal creators.
Literal* GetLiteralTheHole(int position, AstNodeFactory* factory);
// Producing data during the recursive descent.
- const AstRawString* GetSymbol(Scanner* scanner);
- const AstRawString* GetNextSymbol(Scanner* scanner);
- const AstRawString* GetNumberAsSymbol(Scanner* scanner);
-
Expression* ThisExpression(Scope* scope, AstNodeFactory* factory,
int pos = RelocInfo::kNoPosition);
Expression* SuperReference(Scope* scope, AstNodeFactory* factory,
@@ -876,23 +859,12 @@ class Parser : public ParserBase<ParserTraits> {
};
-bool ParserTraits::IsFutureStrictReserved(
- const AstRawString* identifier) const {
- return parser_->scanner()->IdentifierIsFutureStrictReserved(identifier);
-}
-
-
Scope* ParserTraits::NewScope(Scope* parent_scope, ScopeType scope_type,
FunctionKind kind) {
return parser_->NewScope(parent_scope, scope_type, kind);
}
-const AstRawString* ParserTraits::EmptyIdentifierString() {
- return parser_->ast_value_factory()->empty_string();
-}
-
-
void ParserTraits::SkipLazyFunctionBody(const AstRawString* function_name,
int* materialized_literal_count,
int* expected_property_count,
« no previous file with comments | « src/ast-value-factory.h ('k') | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698