Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Side by Side Diff: src/compiler/simplified-lowering.cc

Issue 918143002: Fix missing visitation of FrameState in simplified lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-lowering.h" 5 #include "src/compiler/simplified-lowering.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/base/bits.h" 9 #include "src/base/bits.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 // {kRepTagged} representation and can observe all output values {kTypeAny}. 247 // {kRepTagged} representation and can observe all output values {kTypeAny}.
248 void VisitInputs(Node* node) { 248 void VisitInputs(Node* node) {
249 auto i = node->input_edges().begin(); 249 auto i = node->input_edges().begin();
250 for (int j = node->op()->ValueInputCount(); j > 0; ++i, j--) { 250 for (int j = node->op()->ValueInputCount(); j > 0; ++i, j--) {
251 ProcessInput(node, (*i).index(), kMachAnyTagged); // Value inputs 251 ProcessInput(node, (*i).index(), kMachAnyTagged); // Value inputs
252 } 252 }
253 for (int j = OperatorProperties::GetContextInputCount(node->op()); j > 0; 253 for (int j = OperatorProperties::GetContextInputCount(node->op()); j > 0;
254 ++i, j--) { 254 ++i, j--) {
255 ProcessInput(node, (*i).index(), kMachAnyTagged); // Context inputs 255 ProcessInput(node, (*i).index(), kMachAnyTagged); // Context inputs
256 } 256 }
257 for (int j = OperatorProperties::GetFrameStateInputCount(node->op()); j > 0;
258 ++i, j--) {
259 Enqueue((*i).to()); // FrameState inputs: just visit
260 }
257 for (int j = node->op()->EffectInputCount(); j > 0; ++i, j--) { 261 for (int j = node->op()->EffectInputCount(); j > 0; ++i, j--) {
258 Enqueue((*i).to()); // Effect inputs: just visit 262 Enqueue((*i).to()); // Effect inputs: just visit
259 } 263 }
260 for (int j = node->op()->ControlInputCount(); j > 0; ++i, j--) { 264 for (int j = node->op()->ControlInputCount(); j > 0; ++i, j--) {
261 Enqueue((*i).to()); // Control inputs: just visit 265 Enqueue((*i).to()); // Control inputs: just visit
262 } 266 }
267 DCHECK(i == node->input_edges().end());
263 SetOutput(node, kMachAnyTagged); 268 SetOutput(node, kMachAnyTagged);
264 } 269 }
265 270
266 // Helper for binops of the I x I -> O variety. 271 // Helper for binops of the I x I -> O variety.
267 void VisitBinop(Node* node, MachineTypeUnion input_use, 272 void VisitBinop(Node* node, MachineTypeUnion input_use,
268 MachineTypeUnion output) { 273 MachineTypeUnion output) {
269 DCHECK_EQ(2, node->InputCount()); 274 DCHECK_EQ(2, node->InputCount());
270 ProcessInput(node, 0, input_use); 275 ProcessInput(node, 0, input_use);
271 ProcessInput(node, 1, input_use); 276 ProcessInput(node, 1, input_use);
272 SetOutput(node, output); 277 SetOutput(node, output);
(...skipping 1257 matching lines...) Expand 10 before | Expand all | Expand 10 after
1530 1535
1531 void SimplifiedLowering::DoStringLessThanOrEqual(Node* node) { 1536 void SimplifiedLowering::DoStringLessThanOrEqual(Node* node) {
1532 node->set_op(machine()->IntLessThanOrEqual()); 1537 node->set_op(machine()->IntLessThanOrEqual());
1533 node->ReplaceInput(0, StringComparison(node, true)); 1538 node->ReplaceInput(0, StringComparison(node, true));
1534 node->ReplaceInput(1, jsgraph()->SmiConstant(EQUAL)); 1539 node->ReplaceInput(1, jsgraph()->SmiConstant(EQUAL));
1535 } 1540 }
1536 1541
1537 } // namespace compiler 1542 } // namespace compiler
1538 } // namespace internal 1543 } // namespace internal
1539 } // namespace v8 1544 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698