Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 91813002: blink_tests must only depend on dump_syms#host on mac (Closed)

Created:
7 years ago by jochen (gone - plz use gerrit)
Modified:
7 years ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

blink_tests must only depend on dump_syms#host on mac BUG=none R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237709

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M build/all.gyp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years ago (2013-11-27 15:14:20 UTC) #1
Nico
Looks identical to https://codereview.chromium.org/91803002/ – close that one. Thanks, lgtm. But a nicer fix would ...
7 years ago (2013-11-27 16:17:03 UTC) #2
jochen (gone - plz use gerrit)
On 2013/11/27 16:17:03, Nico wrote: > Looks identical to https://codereview.chromium.org/91803002/ – close that one. It's already ...
7 years ago (2013-11-27 16:27:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/91813002/1
7 years ago (2013-11-27 16:27:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/91813002/1
7 years ago (2013-11-28 02:15:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/91813002/1
7 years ago (2013-11-28 02:50:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/91813002/1
7 years ago (2013-11-28 03:17:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/91813002/1
7 years ago (2013-11-28 03:40:27 UTC) #8
commit-bot: I haz the power
7 years ago (2013-11-28 06:36:25 UTC) #9
Message was sent while issue was closed. 
Change committed as 237709

Powered by Google App Engine
This is Rietveld 408576698