Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 918113002: Fix JSArrayBufferView visitor template to fix ARM build. (Closed)

Created:
5 years, 10 months ago by Hannes Payer (out of office)
Modified:
5 years, 10 months ago
Reviewers:
ulan, Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix JSArrayBufferView visitor template to fix ARM build. NOTREECHECKS=true TBR=ulan@chromium.org Committed: https://crrev.com/295ab2783025237dd7a1c86ddb13690d910622a1 Cr-Commit-Position: refs/heads/master@{#26607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap/objects-visiting.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ulan
lgtm
5 years, 10 months ago (2015-02-12 11:36:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918113002/1
5 years, 10 months ago (2015-02-12 11:36:39 UTC) #3
Michael Achenbach
You need to set NOTREECHECKS=true in the commit message if you want that committed on ...
5 years, 10 months ago (2015-02-12 11:47:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918113002/1
5 years, 10 months ago (2015-02-12 11:48:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-12 11:58:30 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 11:58:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/295ab2783025237dd7a1c86ddb13690d910622a1
Cr-Commit-Position: refs/heads/master@{#26607}

Powered by Google App Engine
This is Rietveld 408576698