|
|
DescriptionAdd apktool and apktool.jar to install-build-deps-android.sh
BUG=452927
Patch Set 1 #Patch Set 2 : Remove unnecessary slash character. #
Total comments: 1
Patch Set 3 : Move URL to next line instead of vars. #
Total comments: 1
Messages
Total messages: 19 (7 generated)
navabi@google.com changed reviewers: + dba@chromium.org, friedman@chromium.org, johnw@google.com, pschmidt@google.com
Thanks for the help Elliot.
ping
friedman@google.com changed reviewers: + friedman@google.com
lgtm https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps... build/install-build-deps-android.sh:115: DownloadBinary apktool /usr/local/bin ${url}/${uri} DownloadBinary apktool /usr/local/bin \ https://raw.githubusercontent.com/iBotPeaches/Apktool/master/scripts/linux/ap... etc
On 2015/02/13 00:11:11, friedman1 wrote: > lgtm > > https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps... > File build/install-build-deps-android.sh (right): > > https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps... > build/install-build-deps-android.sh:115: DownloadBinary apktool /usr/local/bin > ${url}/${uri} > DownloadBinary apktool /usr/local/bin \ > https://raw.githubusercontent.com/iBotPeaches/Apktool/master/scripts/linux/ap... > > etc lgtm--
On 2015/02/13 00:11:20, friedman1 wrote: > On 2015/02/13 00:11:11, friedman1 wrote: > > lgtm > > > > > https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps... > > File build/install-build-deps-android.sh (right): > > > > > https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps... > > build/install-build-deps-android.sh:115: DownloadBinary apktool /usr/local/bin > > ${url}/${uri} > > DownloadBinary apktool /usr/local/bin \ > > > https://raw.githubusercontent.com/iBotPeaches/Apktool/master/scripts/linux/ap... > > > > etc > > lgtm-- lgtm.recind
New patchsets have been uploaded after l-g-t-m from friedman@google.com
ptal
lgtm
The CQ bit was checked by navabi@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918043004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
navabi@google.com changed reviewers: + cjhopman@chromium.org
Adding cjhopman@ for OWNER's review.
https://codereview.chromium.org/918043004/diff/40001/build/install-build-deps... File build/install-build-deps-android.sh (right): https://codereview.chromium.org/918043004/diff/40001/build/install-build-deps... build/install-build-deps-android.sh:114: 'https://raw.githubusercontent.com/iBotPeaches/Apktool/master/scripts/linux/apktool' hm, is this something we should put up on google storage ourselves rather than hitting these other places?
navabi@google.com changed reviewers: + luqui@chromium.org
I uploaded a new CL that uses google storage bucket instead of downloads from a random website as cjhopman@ suggested: https://codereview.chromium.org/1287133002/ I couldn't figure out how to change the user from navabi@chromium.org to navabi@google.com, so it wouldn't let me upload a new patch to this CL. |