Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 918043004: Add apktool and apktool.jar to install-build-deps-android.sh (Closed)

Created:
5 years, 10 months ago by navabi
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add apktool and apktool.jar to install-build-deps-android.sh BUG=452927

Patch Set 1 #

Patch Set 2 : Remove unnecessary slash character. #

Total comments: 1

Patch Set 3 : Move URL to next line instead of vars. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M build/install-build-deps-android.sh View 1 2 1 chunk +19 lines, -0 lines 1 comment Download

Messages

Total messages: 19 (7 generated)
navabi
Thanks for the help Elliot.
5 years, 10 months ago (2015-02-12 01:41:28 UTC) #2
navabi
ping
5 years, 10 months ago (2015-02-13 00:00:03 UTC) #3
friedman1
lgtm https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps-android.sh#newcode115 build/install-build-deps-android.sh:115: DownloadBinary apktool /usr/local/bin ${url}/${uri} DownloadBinary apktool /usr/local/bin \ ...
5 years, 10 months ago (2015-02-13 00:11:11 UTC) #5
friedman1
On 2015/02/13 00:11:11, friedman1 wrote: > lgtm > > https://codereview.chromium.org/918043004/diff/20001/build/install-build-deps-android.sh > File build/install-build-deps-android.sh (right): > ...
5 years, 10 months ago (2015-02-13 00:11:20 UTC) #6
friedman1
On 2015/02/13 00:11:20, friedman1 wrote: > On 2015/02/13 00:11:11, friedman1 wrote: > > lgtm > ...
5 years, 10 months ago (2015-02-13 00:11:36 UTC) #7
navabi
ptal
5 years, 10 months ago (2015-02-13 01:06:25 UTC) #9
friedman1
lgtm
5 years, 10 months ago (2015-02-13 01:36:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/918043004/40001
5 years, 10 months ago (2015-02-17 19:45:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43273)
5 years, 10 months ago (2015-02-17 19:52:52 UTC) #14
navabi
Adding cjhopman@ for OWNER's review.
5 years, 10 months ago (2015-02-17 23:30:45 UTC) #16
cjhopman
https://codereview.chromium.org/918043004/diff/40001/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://codereview.chromium.org/918043004/diff/40001/build/install-build-deps-android.sh#newcode114 build/install-build-deps-android.sh:114: 'https://raw.githubusercontent.com/iBotPeaches/Apktool/master/scripts/linux/apktool' hm, is this something we should put up ...
5 years, 10 months ago (2015-02-18 00:33:06 UTC) #17
navabi
5 years, 4 months ago (2015-08-13 01:20:08 UTC) #19
I uploaded a new CL that uses google storage bucket instead of downloads from a
random website as cjhopman@ suggested:
https://codereview.chromium.org/1287133002/

I couldn't figure out how to change the user from navabi@chromium.org to
navabi@google.com, so it wouldn't let me upload a new patch to this CL.

Powered by Google App Engine
This is Rietveld 408576698