Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/arm/ic-arm.cc

Issue 91803003: Move responsibility for definition of ExtraICState bits into the ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Comment response Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/builtins.h » ('j') | src/ic.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 592 matching lines...) Expand 10 before | Expand all | Expand 10 after
603 603
604 GenerateDictionaryLoad(masm, &slow_load, r0, r2, r1, r3, r4); 604 GenerateDictionaryLoad(masm, &slow_load, r0, r2, r1, r3, r4);
605 __ IncrementCounter(counters->keyed_call_generic_lookup_dict(), 1, r0, r3); 605 __ IncrementCounter(counters->keyed_call_generic_lookup_dict(), 1, r0, r3);
606 __ jmp(&do_call); 606 __ jmp(&do_call);
607 607
608 __ bind(&lookup_monomorphic_cache); 608 __ bind(&lookup_monomorphic_cache);
609 __ IncrementCounter(counters->keyed_call_generic_lookup_cache(), 1, r0, r3); 609 __ IncrementCounter(counters->keyed_call_generic_lookup_cache(), 1, r0, r3);
610 GenerateMonomorphicCacheProbe(masm, 610 GenerateMonomorphicCacheProbe(masm,
611 argc, 611 argc,
612 Code::KEYED_CALL_IC, 612 Code::KEYED_CALL_IC,
613 Code::kNoExtraICState); 613 IC::kNoExtraICState);
614 // Fall through on miss. 614 // Fall through on miss.
615 615
616 __ bind(&slow_call); 616 __ bind(&slow_call);
617 // This branch is taken if: 617 // This branch is taken if:
618 // - the receiver requires boxing or access check, 618 // - the receiver requires boxing or access check,
619 // - the key is neither smi nor a unique name, 619 // - the key is neither smi nor a unique name,
620 // - the value loaded is not a function, 620 // - the value loaded is not a function,
621 // - there is hope that the runtime will create a monomorphic call stub 621 // - there is hope that the runtime will create a monomorphic call stub
622 // that will get fetched next time. 622 // that will get fetched next time.
623 __ IncrementCounter(counters->keyed_call_generic_slow(), 1, r0, r3); 623 __ IncrementCounter(counters->keyed_call_generic_slow(), 1, r0, r3);
(...skipping 25 matching lines...) Expand all
649 649
650 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) { 650 void LoadIC::GenerateMegamorphic(MacroAssembler* masm) {
651 // ----------- S t a t e ------------- 651 // ----------- S t a t e -------------
652 // -- r2 : name 652 // -- r2 : name
653 // -- lr : return address 653 // -- lr : return address
654 // -- r0 : receiver 654 // -- r0 : receiver
655 // ----------------------------------- 655 // -----------------------------------
656 656
657 // Probe the stub cache. 657 // Probe the stub cache.
658 Code::Flags flags = Code::ComputeFlags( 658 Code::Flags flags = Code::ComputeFlags(
659 Code::HANDLER, MONOMORPHIC, Code::kNoExtraICState, 659 Code::HANDLER, MONOMORPHIC, IC::kNoExtraICState,
660 Code::NORMAL, Code::LOAD_IC); 660 Code::NORMAL, Code::LOAD_IC);
661 masm->isolate()->stub_cache()->GenerateProbe( 661 masm->isolate()->stub_cache()->GenerateProbe(
662 masm, flags, r0, r2, r3, r4, r5, r6); 662 masm, flags, r0, r2, r3, r4, r5, r6);
663 663
664 // Cache miss: Jump to runtime. 664 // Cache miss: Jump to runtime.
665 GenerateMiss(masm); 665 GenerateMiss(masm);
666 } 666 }
667 667
668 668
669 void LoadIC::GenerateNormal(MacroAssembler* masm) { 669 void LoadIC::GenerateNormal(MacroAssembler* masm) {
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
1677 } else { 1677 } else {
1678 ASSERT(Assembler::GetCondition(branch_instr) == ne); 1678 ASSERT(Assembler::GetCondition(branch_instr) == ne);
1679 patcher.EmitCondition(eq); 1679 patcher.EmitCondition(eq);
1680 } 1680 }
1681 } 1681 }
1682 1682
1683 1683
1684 } } // namespace v8::internal 1684 } } // namespace v8::internal
1685 1685
1686 #endif // V8_TARGET_ARCH_ARM 1686 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/builtins.h » ('j') | src/ic.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698