Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Unified Diff: runtime/observatory/test/command_test.dart

Issue 918003002: Add 'break' and 'clear' commands to Observatory debugger. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fixups Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/test/command_test.dart
diff --git a/runtime/observatory/test/command_test.dart b/runtime/observatory/test/command_test.dart
index b87631ebbe75b29d6b44f7ef5af5588f590606b7..81599819d7997b0b45f008c00fb0ea5aa9c2d72c 100644
--- a/runtime/observatory/test/command_test.dart
+++ b/runtime/observatory/test/command_test.dart
@@ -21,9 +21,10 @@ class TestCompleteCommand extends Command {
TestCompleteCommand(this.out, name, children) : super(name, children);
StringBuffer out;
- List<String> complete(List<String> args) {
+ Future<List<String>> complete(List<String> args) {
var possibles = ['one ', 'two ', 'three '];
- return possibles.where((possible) => possible.startsWith(args[0])).toList();
+ return new Future.value(
+ possibles.where((possible) => possible.startsWith(args[0])).toList());
}
Future run(List<String> args) {
@@ -49,79 +50,98 @@ void testCommandComplete() {
new TestCommand(null, 'chocula', [])])]);
// Show all commands.
- expect(cmd.completeCommand(''),
- equals(['alpha ', 'game ', 'gamera ', 'count ']));
+ cmd.completeCommand('').then((result) {
+ expect(result, equals(['alpha ', 'game ', 'gamera ', 'count ']));
+ });
// Substring completion.
- expect(cmd.completeCommand('al'),
- equals(['alpha ']));
+ cmd.completeCommand('al').then((result) {
+ expect(result, equals(['alpha ']));
+ });
// Full string completion.
- expect(cmd.completeCommand('alpha'),
- equals(['alpha ']));
+ cmd.completeCommand('alpha').then((result) {
+ expect(result, equals(['alpha ']));
+ });
// Extra space, no subcommands.
- expect(cmd.completeCommand('alpha '),
- equals(['alpha ']));
+ cmd.completeCommand('alpha ').then((result) {
+ expect(result, equals(['alpha ']));
+ });
// Ambiguous completion.
- expect(cmd.completeCommand('g'),
- equals(['game ', 'gamera ']));
+ cmd.completeCommand('g').then((result) {
+ expect(result, equals(['game ', 'gamera ']));
+ });
// Ambiguous completion, exact match not preferred.
- expect(cmd.completeCommand('game'),
- equals(['game ', 'gamera ']));
+ cmd.completeCommand('game').then((result) {
+ expect(result, equals(['game ', 'gamera ']));
+ });
// Show all subcommands.
- expect(cmd.completeCommand('gamera '),
- equals(['gamera london ', 'gamera tokyo ', 'gamera topeka ']));
+ cmd.completeCommand('gamera ').then((result) {
+ expect(result, equals(['gamera london ', 'gamera tokyo ', 'gamera topeka ']));
+ });
// Subcommand completion.
- expect(cmd.completeCommand('gamera l'),
- equals(['gamera london ']));
+ cmd.completeCommand('gamera l').then((result) {
+ expect(result, equals(['gamera london ']));
+ });
// Extra space, with subcommand.
- expect(cmd.completeCommand('gamera london '),
- equals(['gamera london ']));
+ cmd.completeCommand('gamera london ').then((result) {
+ expect(result, equals(['gamera london ']));
+ });
// Ambiguous subcommand completion.
- expect(cmd.completeCommand('gamera t'),
- equals(['gamera tokyo ', 'gamera topeka ']));
+ cmd.completeCommand('gamera t').then((result) {
+ expect(result, equals(['gamera tokyo ', 'gamera topeka ']));
+ });
// Ambiguous subcommand completion with substring prefix.
// Note that the prefix is left alone.
- expect(cmd.completeCommand('gamer t'),
- equals(['gamer tokyo ', 'gamer topeka ']));
+ cmd.completeCommand('gamer t').then((result) {
+ expect(result, equals(['gamer tokyo ', 'gamer topeka ']));
+ });
// Ambiguous but exact prefix is preferred.
- expect(cmd.completeCommand('game chec'),
- equals(['game checkers ']));
+ cmd.completeCommand('game chec').then((result) {
+ expect(result, equals(['game checkers ']));
+ });
// Ambiguous non-exact prefix means no matches.
- expect(cmd.completeCommand('gam chec'),
- equals([]));
+ cmd.completeCommand('gam chec').then((result) {
+ expect(result, equals([]));
+ });
// Locals + subcommands, show all.
- expect(cmd.completeCommand('count '),
- equals(['count chocula ',
- 'count one ',
- 'count two ',
- 'count three ']));
+ cmd.completeCommand('count ').then((result) {
+ expect(result, equals(['count chocula ',
+ 'count one ',
+ 'count two ',
+ 'count three ']));
+ });
// Locals + subcommands, single local match.
- expect(cmd.completeCommand('count th '),
- equals(['count three ']));
+ cmd.completeCommand('count th ').then((result) {
+ expect(result, equals(['count three ']));
+ });
// Locals + subcommands, ambiguous local match.
- expect(cmd.completeCommand('count t'),
- equals(['count two ', 'count three ']));
+ cmd.completeCommand('count t').then((result) {
+ expect(result, equals(['count two ', 'count three ']));
+ });
// Locals + subcommands, single command match.
- expect(cmd.completeCommand('co choc'),
- equals(['co chocula ']));
+ cmd.completeCommand('co choc').then((result) {
+ expect(result, equals(['co chocula ']));
+ });
// We gobble spare spaces, even in the prefix.
- expect(cmd.completeCommand(' game chec'), equals(['game checkers ']));
+ cmd.completeCommand(' game chec').then((result) {
+ expect(result, equals(['game checkers ']));
+ });
}
void testCommandRunSimple() {

Powered by Google App Engine
This is Rietveld 408576698