DM: JSON output adds process_max_resident_set_size_MB

DM: JSON output adds process_max_resident_set_size_MB

Committed: https://skia.googlesource.com/skia/+/c79a391a38c68503e43dc0ca775db9ed161f00b0

[hal.canary, 2015-02-11 22:09:46]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2015-02-11 22:09:47]

PTAL

[mtklein, 2015-02-11 22:27:17]

mtklein@google.com changed reviewers:
+ jcgregorio@google.com

[mtklein, 2015-02-11 22:27:17]

mtklein@google.com changed required reviewers:
+ jcgregorio@google.com

[mtklein, 2015-02-11 22:27:17]

lgtm

[hal.canary, 2015-02-11 22:27:52]

The CQ bit was checked by halcanary@google.com

[commit-bot: I haz the power, 2015-02-11 22:28:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917943002/1

[commit-bot: I haz the power, 2015-02-11 22:28:46]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-12 04:28 UTC

[robertphillips, 2015-02-11 22:54:05]

robertphillips@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-02-11 22:54:05]

lgtm

[robertphillips, 2015-02-11 23:02:10]

The CQ bit was unchecked by robertphillips@google.com

[robertphillips, 2015-02-11 23:02:11]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2015-02-11 23:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917943002/1

[commit-bot: I haz the power, 2015-02-11 23:02:17]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-02-12 05:02 UTC

[bsalomon, 2015-02-11 23:03:56]

bsalomon@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2015-02-11 23:03:56]

lgtm ?

[mtklein, 2015-02-11 23:17:38]

On 2015/02/11 23:03:56, bsalomon wrote:
> lgtm ?

Sorry, I guess this was subtle.  I added Joe as a required reviewer when LGTMing
the CL.

[hal.canary, 2015-02-11 23:18:41]

On 2015/02/11 23:17:38, mtklein wrote:
> On 2015/02/11 23:03:56, bsalomon wrote:
> > lgtm ?
> 
> Sorry, I guess this was subtle.  I added Joe as a required reviewer when
LGTMing
> the CL.

Is it the star next to his name?

[mtklein, 2015-02-11 23:30:34]

> Is it the star next to his name?
Yes.

[commit-bot: I haz the power, 2015-02-12 05:02:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-12 05:02:23]

All required reviewers (with asterisk prefixes) have not yet approved this CL.

No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer from
https://skia.googlesource.com/skia/+/master/CQ_COMMITTERS

[jcgregorio, 2015-02-12 13:15:01]

https://codereview.chromium.org/917943002/diff/1/dm/DMJsonWriter.cpp
File dm/DMJsonWriter.cpp (right):

https://codereview.chromium.org/917943002/diff/1/dm/DMJsonWriter.cpp#newcode80
dm/DMJsonWriter.cpp:80: root["process_max_resident_set_size_MB"] =
Can you think of a slightly shorter name?

Also, does this mean you would like perf to ingest DM results also?

[hal.canary, 2015-04-01 20:12:26]

https://codereview.chromium.org/917943002/diff/1/dm/DMJsonWriter.cpp
File dm/DMJsonWriter.cpp (right):

https://codereview.chromium.org/917943002/diff/1/dm/DMJsonWriter.cpp#newcode80
dm/DMJsonWriter.cpp:80: root["process_max_resident_set_size_MB"] =
On 2015/02/12 13:15:00, jcgregorio wrote:
> Can you think of a slightly shorter name?

Done

[jcgregorio, 2015-04-01 20:14:26]

lgtm

[hal.canary, 2015-04-01 20:20:12]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2015-04-01 20:20:12]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com,
robertphillips@google.com, bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/917943002/#ps20001 (title:
"2015-04-01 (Wednesday) 16:11:58 EDT")

[commit-bot: I haz the power, 2015-04-01 20:20:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917943002/20001

[commit-bot: I haz the power, 2015-04-01 20:31:41]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c79a391a38c68503e43dc0ca775db9ed161f00b0