Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 917933007: Make super() a syntax error in base class constructor (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make super() a syntax error in base class constructor BUG=v8:3330 LOG=N R=dslomov@chromium.org Committed: https://crrev.com/1dcce1c8efa111568eb97747b3e3aa9d178aa8c9 Cr-Commit-Position: refs/heads/master@{#26633}

Patch Set 1 #

Patch Set 2 : expand tests slightly #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M src/preparser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 8 chunks +11 lines, -21 lines 1 comment Download
M test/message/super-constructor.out View 1 chunk +3 lines, -5 lines 0 comments Download
M test/message/super-constructor-extra-statement.out View 1 chunk +3 lines, -5 lines 0 comments Download
M test/mjsunit/harmony/classes-experimental.js View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
arv (Not doing code reviews)
expand tests slightly
5 years, 10 months ago (2015-02-12 21:09:59 UTC) #1
arv (Not doing code reviews)
PTAL https://codereview.chromium.org/917933007/diff/20001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (left): https://codereview.chromium.org/917933007/diff/20001/test/cctest/test-parsing.cc#oldcode963 test/cctest/test-parsing.cc:963: SUPER_CONSTRUCTOR_CALL = 1 << 2, I decided to ...
5 years, 10 months ago (2015-02-12 21:11:28 UTC) #2
Dmitry Lomov (no reviews)
lgtm
5 years, 10 months ago (2015-02-12 22:48:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917933007/20001
5 years, 10 months ago (2015-02-12 22:49:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2964)
5 years, 10 months ago (2015-02-12 22:56:15 UTC) #7
arv (Not doing code reviews)
Committed patchset #2 (id:20001) manually as 1dcce1c8efa111568eb97747b3e3aa9d178aa8c9 (presubmit successful).
5 years, 10 months ago (2015-02-12 23:05:01 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 23:05:02 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1dcce1c8efa111568eb97747b3e3aa9d178aa8c9
Cr-Commit-Position: refs/heads/master@{#26633}

Powered by Google App Engine
This is Rietveld 408576698