Issue 917913004: Generated makefile now includes people to contact.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 917913004: Generated makefile now includes people to contact. (Closed)

Created:
5 years, 10 months ago by scroggo

Modified:
5 years, 10 months ago

Reviewers:
djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -0 lines)			Patch
M	platform_tools/android/gyp_gen/makefile_writer.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	platform_tools/android/tests/expectations/Android.mk	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	platform_tools/android/tests/expectations/tool/Android.mk	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

scroggo

Hopefully this will lead people confused about breakages to us.

5 years, 10 months ago (2015-02-12 15:52:53 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917913004/1

5 years, 10 months ago (2015-02-12 16:14:34 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-12 16:20:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9d7ceca35064b71e13e498da7e641e69b97bf4cf