Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: net/proxy/proxy_resolver_mojo.h

Issue 917863005: Implementation of ProxyResolver that uses a Mojo service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@sam-v8-pac-utility-proxy
Patch Set: Fix build rules. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/proxy/proxy_resolver_mojo.h
diff --git a/net/proxy/proxy_resolver_mojo.h b/net/proxy/proxy_resolver_mojo.h
new file mode 100644
index 0000000000000000000000000000000000000000..721e2d44416a7c013f1930e1890fdad21f68bea1
--- /dev/null
+++ b/net/proxy/proxy_resolver_mojo.h
@@ -0,0 +1,101 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_PROXY_PROXY_RESOLVER_MOJO_H_
+#define NET_PROXY_PROXY_RESOLVER_MOJO_H_
+
+#include <set>
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/threading/thread_checker.h"
+#include "net/base/completion_callback.h"
+#include "net/base/load_states.h"
+#include "net/interfaces/host_resolver_service.mojom.h"
+#include "net/interfaces/proxy_resolver_service.mojom.h"
+#include "net/proxy/proxy_resolver.h"
+#include "net/proxy/proxy_resolver_script_data.h"
+#include "third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h"
+
+class GURL;
+
+namespace net {
+
+class BoundNetLog;
+class HostResolver;
+class ProxyInfo;
+class MojoProxyResolverFactory;
+
+// Implementation of ProxyResolver that connects to a Mojo service to evaluate
+// PAC scripts. This implementation only knows about Mojo services, and
+// therefore that service may live in or out of process.
+//
+// This implementation handles disconnections from the Mojo service (i.e. if the
+// service is out-of-process and that process crashes) and transparently
+// re-connects to a new service.
+class ProxyResolverMojo : public ProxyResolver, public mojo::ErrorHandler {
+ public:
+ // Constructs a ProxyResolverMojo and connects to a new Mojo proxy resolver
+ // service using |proxy_resolver_factory|. The new Mojo proxy resolver uses
+ // |host_resolver| as the DNS resolver. |proxy_resolver_factory| and
+ // |host_resolver| are not owned and must outlive this.
+ // TODO(amistry): Add ProxyResolverErrorObserver and NetLog.
+ explicit ProxyResolverMojo(MojoProxyResolverFactory* proxy_resolver_factory,
Sam McNally 2015/02/16 05:52:38 No explicit.
Anand Mistry (off Chromium) 2015/02/17 05:49:21 Done.
+ HostResolver* host_resolver);
+ ~ProxyResolverMojo() override;
+
+ // ProxyResolver implementation:
+ int GetProxyForURL(const GURL& url,
+ ProxyInfo* results,
+ const net::CompletionCallback& callback,
+ RequestHandle* request,
+ const BoundNetLog& net_log) override;
+ void CancelRequest(RequestHandle request) override;
+ LoadState GetLoadState(RequestHandle request) const override;
+ void CancelSetPacScript() override;
+ int SetPacScript(const scoped_refptr<ProxyResolverScriptData>& pac_script,
+ const net::CompletionCallback& callback) override;
+
+ private:
+ class Job;
+
+ // Overridden from mojo::ErrorHandler:
+ void OnConnectionError() override;
+
+ // Callback for ProxyResolverService::SetPacScript.
+ void OnSetPacScriptDone(int32_t result);
+
+ void SetupServices();
Sam McNally 2015/02/16 05:52:38 SetUpServices
Anand Mistry (off Chromium) 2015/02/17 05:49:21 Done.
+
+ void CancelPendingRequests();
+
+ void RemoveJob(Job* job);
+
+ // Connection to the Mojo proxy resolver.
+ interfaces::ProxyResolverPtr proxy_resolver_ptr_;
+
+ // Binding to the Mojo host resolver.
+ scoped_ptr<mojo::StrongBinding<interfaces::HostResolver>>
+ host_resolver_binding_;
+
+ // Factory for connecting to new Mojo proxy resolvers.
+ // Not owned.
+ MojoProxyResolverFactory* proxy_resolver_factory_;
+
+ // Parameters for creating a new Mojo proxy resolver when the existing one
+ // disconnects (i.e. when utility process crashes).
+ HostResolver* host_resolver_;
+ scoped_refptr<ProxyResolverScriptData> pac_script_;
+
+ std::set<Job*> pending_jobs_;
+ net::CompletionCallback set_pac_script_callback_;
+
+ base::ThreadChecker thread_checker_;
+
+ DISALLOW_COPY_AND_ASSIGN(ProxyResolverMojo);
+};
+
+} // namespace net
+
+#endif // NET_PROXY_PROXY_RESOLVER_MOJO_H_

Powered by Google App Engine
This is Rietveld 408576698