Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h

Issue 917863003: [Extensions UI Mac] Wire up Mac to use the ExtensionInstalledBubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
diff --git a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
index aec68981ac6511392286cada9fa4502e544751b9..11053b4ab27237d936f342a6f8c0998b3345bd3e 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
+++ b/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h
@@ -13,7 +13,8 @@
#include "third_party/skia/include/core/SkBitmap.h"
class Browser;
-class ExtensionLoadedNotificationObserver;
+class ExtensionInstalledBubble;
+class ExtensionInstalledBubbleBridge;
@class HyperlinkTextView;
@class HoverCloseButton;
@class InfoBubbleView;
@@ -69,10 +70,11 @@ typedef enum {
// doesn't overlap browser destruction.
BOOL pageActionPreviewShowing_;
- // Lets us register for EXTENSION_LOADED notifications. The actual
- // notifications are sent to the observer object, which proxies them
- // back to the controller.
- scoped_ptr<ExtensionLoadedNotificationObserver> extensionObserver_;
+ // The bridge to the C++ object that performs shared logic across platforms,
+ // like listening for the notification that the extension is loaded. This
+ // tells us when to show the bubble.
+ scoped_ptr<ExtensionInstalledBubbleBridge> installedBubbleBridge_;
+ scoped_ptr<ExtensionInstalledBubble> installedBubble_;
// References below are weak, being obtained from the nib.
IBOutlet HoverCloseButton* closeButton_;
@@ -99,7 +101,6 @@ typedef enum {
IBOutlet NSTextField* failedItemsMsg_;
}
-@property(nonatomic, readonly) const extensions::Extension* extension;
@property(nonatomic, readonly) const extensions::BundleInstaller* bundle;
@property(nonatomic) BOOL pageActionPreviewShowing;
@@ -123,10 +124,6 @@ typedef enum {
// the extensionObserver when the extension has completed loading.
- (void)showWindow:(id)sender;
-// Clears our weak pointer to the Extension. This callback is triggered by
-// the extensionObserver when the extension is unloaded.
-- (void)extensionUnloaded:(id)sender;
-
// Opens the shortcut configuration UI.
- (IBAction)onManageShortcutClicked:(id)sender;

Powered by Google App Engine
This is Rietveld 408576698