Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 917863003: [Extensions UI Mac] Wire up Mac to use the ExtensionInstalledBubble (Closed)

Created:
5 years, 10 months ago by Devlin
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions UI Mac] Wire up Mac to use the ExtensionInstalledBubble There's a good amount of platform-agnostic work done in the extension installed bubble classes, and we have the groundwork for a shared controller in ExtensionInstalledBubble. Wire up the Cocoa implementation (ExtensionInstalledBubbleController) to use this so we can begin moving more shared logic into the shared class. BUG=458301 Committed: https://crrev.com/69db60ecb2e418d5f1229b65ead3b26fce92eee2 Cr-Commit-Position: refs/heads/master@{#316260}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Robert's #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -76 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.h View 4 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm View 1 14 chunks +54 lines, -66 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Devlin
Robert, mind taking a look? This patch just sets us up to move some shared ...
5 years, 10 months ago (2015-02-12 22:15:18 UTC) #2
Robert Sesek
I was going to comment about the method organization of extension_installed_bubble_controller.mm but it's kind of ...
5 years, 10 months ago (2015-02-12 23:47:35 UTC) #3
Devlin
> I was going to comment about the method organization of > extension_installed_bubble_controller.mm but it's ...
5 years, 10 months ago (2015-02-13 01:11:50 UTC) #5
Robert Sesek
lgtm
5 years, 10 months ago (2015-02-13 01:14:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917863003/40001
5 years, 10 months ago (2015-02-13 19:22:31 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 10 months ago (2015-02-13 19:26:02 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 19:26:38 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69db60ecb2e418d5f1229b65ead3b26fce92eee2
Cr-Commit-Position: refs/heads/master@{#316260}

Powered by Google App Engine
This is Rietveld 408576698