Resetting FrameTreeNode must remove child FrameTreeNodes from global map.

content/browser/frame_host/frame_tree_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree_node.h"
 
 #include <queue>
 
 #include "base/command_line.h"
 #include "base/stl_util.h"
@@ skipping 74 matching lines @@
   }
 }
 
 void FrameTreeNode::ResetForNewProcess() {
   current_url_ = GURL();
 
   // The children may not have been cleared if a cross-process navigation
   // commits before the old process cleans everything up.  Make sure the child
   // nodes get deleted before swapping to a new process.
   ScopedVector<FrameTreeNode> old_children = children_.Pass();
+
+  // Loop over all children removing them from the FrameTree. This will ensure
+  // that nodes are properly remove from the tree and notifications are sent.

[Charlie Reis, 2015/02/12 23:26:07]

nit: removed

[nasko, 2015/02/12 23:30:51]

Done.

+  // Note: since the |children_| vector is now empty, the calls into RemoveChild
+  // will be a noop and will not result in traversing twice through the list.

[Charlie Reis, 2015/02/12 23:26:07]

nit: no-op
nit: s/traversing twice through/repeatedly traversing/

[nasko, 2015/02/12 23:30:51]

Done.

+  for (const auto& child : old_children) {

[Charlie Reis, 2015/02/12 23:26:07]

nit: No braces needed.

[nasko, 2015/02/12 23:30:51]

Done.

+    frame_tree_->RemoveFrame(child);
+  }
   old_children.clear();  // May notify observers.
 }
 
 bool FrameTreeNode::IsDescendantOf(FrameTreeNode* other) const {
   if (!other || !other->child_count())
     return false;
 
   for (FrameTreeNode* node = parent(); node; node = node->parent()) {
     if (node == other)
       return true;
   }
 
   return false;
 }
 
 }  // namespace content