Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 917793002: Use pub_server package (Closed)

Created:
5 years, 10 months ago by kustermann
Modified:
5 years, 10 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub-dartlang-dart.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -934 lines) Patch
M Dockerfile View 1 chunk +1 line, -1 line 0 comments Download
M app/bin/server_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M app/lib/appengine_repository.dart View 1 chunk +1 line, -1 line 0 comments Download
M app/lib/upload_signer_service.dart View 1 chunk +1 line, -1 line 0 comments Download
M app/pubspec.lock View 8 chunks +13 lines, -13 lines 0 comments Download
M app/pubspec.yaml View 2 chunks +3 lines, -2 lines 0 comments Download
M codereview.settings View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/pub_server/AUTHORS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/pub_server/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/pub_server/PATENTS View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/pub_server/codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download
A + pkg/pub_server/lib/repository.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/pub_server/lib/shelf_pubserver.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/pub_server/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
A + pkg/pub_server/test/shelf_pubserver_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
D pkg/pubserver/lib/repository.dart View 1 chunk +0 lines, -119 lines 0 comments Download
D pkg/pubserver/lib/shelf_pubserver.dart View 1 chunk +0 lines, -401 lines 0 comments Download
D pkg/pubserver/pubspec.yaml View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/pubserver/test/shelf_pubserver_test.dart View 1 chunk +0 lines, -371 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
kustermann
Changes the code to use the pub_server package. As long as we might want changes ...
5 years, 10 months ago (2015-02-11 15:09:52 UTC) #2
Søren Gjesse
lgtm
5 years, 10 months ago (2015-02-11 15:49:01 UTC) #3
kustermann
5 years, 10 months ago (2015-02-11 16:09:14 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
80f9dd3e6b67d29f26b3dbc37b8d723724dc3f6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698