Source/core/html/HTMLCanvasElement.h - Issue 917733002: HTMLCanvasElement.toDataURL should use IDL 'any' to avoid using custom binding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLCanvasElement.h

Issue 917733002: HTMLCanvasElement.toDataURL should use IDL 'any' to avoid using custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Using any -> ScriptValue Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLCanvasElement.h

diff --git a/Source/core/html/HTMLCanvasElement.h b/Source/core/html/HTMLCanvasElement.h

index 0b187f58a6842dc0b4154830b38baef8dc4e2095..0c1c35cadbcba6910e72af0a6a187564e6cf7749 100644

--- a/Source/core/html/HTMLCanvasElement.h

+++ b/Source/core/html/HTMLCanvasElement.h

@@ -108,8 +108,8 @@ public:

bool isPaintable() const;

static String toEncodingMimeType(const String& mimeType);

- String toDataURL(const String& mimeType, const double* quality, ExceptionState&) const;

- String toDataURL(const String& mimeType, ExceptionState& exceptionState) const { return toDataURL(mimeType, 0, exceptionState); }

+ String toDataURL(const String& mimeType, const ScriptValue& qualityArgument, ExceptionState&) const;

+ String toDataURL(const String& mimeType, ExceptionState& exceptionState) const { return toDataURL(mimeType, ScriptValue(), exceptionState); }

// Used for rendering

void didDraw(const FloatRect&);

« no previous file with comments | « Source/bindings/core/v8/custom/custom.gypi ('k') | Source/core/html/HTMLCanvasElement.cpp » ('j') | Source/core/html/HTMLCanvasElement.cpp » ('J')