Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Side by Side Diff: Source/core/html/HTMLCanvasElement.idl

Issue 917733002: HTMLCanvasElement.toDataURL should use IDL 'any' to avoid using custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing! Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLCanvasElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008, 2009 Apple Inc. All rights reserved.
3 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved. 3 * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 13 matching lines...) Expand all
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 typedef (CanvasRenderingContext2D or WebGLRenderingContext) RenderingContext; 27 typedef (CanvasRenderingContext2D or WebGLRenderingContext) RenderingContext;
28 28
29 interface HTMLCanvasElement : HTMLElement { 29 interface HTMLCanvasElement : HTMLElement {
30 30
31 attribute long width; 31 attribute long width;
32 attribute long height; 32 attribute long height;
33 33
34 [Custom, RaisesException] DOMString toDataURL([TreatUndefinedAs=NullString, Default=Undefined] optional DOMString? type); 34 [RaisesException] DOMString toDataURL([TreatUndefinedAs=NullString, Default= Undefined] optional DOMString? type, optional any arguments);
Jens Widell 2015/02/11 20:18:55 BTW, the first argument could equivalently be decl
35 35
36 // Note: this differs deliberately from the specified Web IDL for this funct ion: 36 // Note: this differs deliberately from the specified Web IDL for this funct ion:
37 // RenderingContext? getContext(DOMString contextId, any... arguments); 37 // RenderingContext? getContext(DOMString contextId, any... arguments);
38 // in order to eliminate the custom binding. It is functionally equivalent. 38 // in order to eliminate the custom binding. It is functionally equivalent.
39 // 39 //
40 // The PermissiveDictionaryConversion extended attribute is needed to allow the 40 // The PermissiveDictionaryConversion extended attribute is needed to allow the
41 // autogenerated code to match the behavior of the custom binding. Web IDL 41 // autogenerated code to match the behavior of the custom binding. Web IDL
42 // requires throwing TypeError if the incoming argument is not an object typ e 42 // requires throwing TypeError if the incoming argument is not an object typ e
43 // (and is not undefined or null). The binding must ignore this. 43 // (and is not undefined or null). The binding must ignore this.
44 // 44 //
45 // Also note: the only reason this must return type "any" is to allow the 45 // Also note: the only reason this must return type "any" is to allow the
46 // InspectorInstrumentation wrappers to be called for canvases. If that coul d be 46 // InspectorInstrumentation wrappers to be called for canvases. If that coul d be
47 // handled differently the return type could be changed to "RenderingContext ?" 47 // handled differently the return type could be changed to "RenderingContext ?"
48 // and the [CallWith=ScriptState] extended attribute removed. 48 // and the [CallWith=ScriptState] extended attribute removed.
49 [CallWith=ScriptState] any getContext([Default=Undefined] optional DOMString contextId, [PermissiveDictionaryConversion] optional CanvasContextCreationAttri butes attributes); 49 [CallWith=ScriptState] any getContext([Default=Undefined] optional DOMString contextId, [PermissiveDictionaryConversion] optional CanvasContextCreationAttri butes attributes);
50 }; 50 };
OLDNEW
« no previous file with comments | « Source/core/html/HTMLCanvasElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698