[strong] no sloppy equality

[strong] no sloppy equality

R=marja@chromium.org
BUG=

Committed: https://crrev.com/dff690ec0763721808582c7bd382768091648d0e
Cr-Commit-Position: refs/heads/master@{#26619}

[arv (Not doing code reviews), 2015-02-11 16:30:43]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-02-11 16:30:44]

LGTM

[marja, 2015-02-12 09:59:37]

lgtm

https://codereview.chromium.org/917703003/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/917703003/diff/1/src/messages.js#newcode164
src/messages.js:164: strong_equal:                  ["Please don't use '==' or
'!=' in strong mode, use '===' or '!==' instead"],
I find this error message strangely polite :) How about:

'==' and '!=' not allowed in strong mode

https://codereview.chromium.org/917703003/diff/1/test/mjsunit/strong/equality.js
File test/mjsunit/strong/equality.js (right):

https://codereview.chromium.org/917703003/diff/1/test/mjsunit/strong/equality...
test/mjsunit/strong/equality.js:13: assertTrue(eval("function f() { 'use strong'
} 0 != 1"));
Some of these could theoretically be parser sync tests in test-parsing.cc, but
it's not super interesting since those parts of parser / preparser are already
unified.

[rossberg, 2015-02-12 14:47:17]

https://codereview.chromium.org/917703003/diff/1/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/917703003/diff/1/src/messages.js#newcode164
src/messages.js:164: strong_equal:                  ["Please don't use '==' or
'!=' in strong mode, use '===' or '!==' instead"],
On 2015/02/12 09:59:37, marja wrote:
> I find this error message strangely polite :)

Totally intentional, I thought people should think good of strong mode instead
of feeling harassed. :)

The "please" might be over the top, but at least I'd like strong mode errors to
point out the recommended alternative to using the forbidden feature.

[rossberg, 2015-02-12 14:47:21]

The CQ bit was checked by rossberg@chromium.org

[commit-bot: I haz the power, 2015-02-12 14:48:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917703003/1

[commit-bot: I haz the power, 2015-02-12 15:10:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-12 15:10:20]

Patchset 1 (id:??) landed as
https://crrev.com/dff690ec0763721808582c7bd382768091648d0e
Cr-Commit-Position: refs/heads/master@{#26619}

[marja, 2015-02-12 15:43:35]

tsan seems unhappy:

http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/252...