Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 917633002: Block esc, back button and cancel button until gaia is loaded. (Closed)

Created:
5 years, 10 months ago by Roman Sorokin (ftl)
Modified:
5 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Block esc, back button and cancel button until gaia is loaded. BUG=454042 Committed: https://crrev.com/122ef7aa45af61133c4a4db49569f81cb4b36ab1 Cr-Commit-Position: refs/heads/master@{#315769}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 5 chunks +28 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Roman Sorokin (ftl)
Nikita, please review
5 years, 10 months ago (2015-02-11 08:46:08 UTC) #2
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-11 14:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917633002/1
5 years, 10 months ago (2015-02-11 15:51:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-11 16:22:07 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-11 16:25:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/122ef7aa45af61133c4a4db49569f81cb4b36ab1
Cr-Commit-Position: refs/heads/master@{#315769}

Powered by Google App Engine
This is Rietveld 408576698