Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/dom/Element.h

Issue 917613004: Add isTabStop attribute to Element (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Add a layout test and fix missing isTabStop() case. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« LayoutTests/fast/dom/shadow/focusable-elements-with-istabstop.html ('K') | « LayoutTests/webexposed/element-instance-property-listing-expected.txt ('k') | Source/core/dom/Element.cpp » ('j') | Source/core/dom/Element.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.h
diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h
index 3a79335f875c4b1ca9768b3ffedc51ff87e52c34..158496baa792114a16c091d6ef0481b835d623c2 100644
--- a/Source/core/dom/Element.h
+++ b/Source/core/dom/Element.h
@@ -374,6 +374,8 @@ public:
virtual bool supportsFocus() const;
// Whether the node can actually be focused.
bool isFocusable() const;
+ bool isTabStop() const;
+ void setIsTabStop(bool);
virtual bool isKeyboardFocusable() const;
virtual bool isMouseFocusable() const;
virtual void dispatchFocusEvent(Element* oldFocusedElement, WebFocusType);
@@ -648,6 +650,7 @@ private:
v8::Handle<v8::Object> wrapCustomElement(v8::Isolate*, v8::Handle<v8::Object> creationContext);
RefPtrWillBeMember<ElementData> m_elementData;
+ bool m_isTabStop;
hayato 2015/02/20 08:46:31 How about moving this to ElementRareData?
kochi 2015/02/20 09:43:05 Yes, I should have done... Done.
};
DEFINE_NODE_TYPE_CASTS(Element, isElementNode());
« LayoutTests/fast/dom/shadow/focusable-elements-with-istabstop.html ('K') | « LayoutTests/webexposed/element-instance-property-listing-expected.txt ('k') | Source/core/dom/Element.cpp » ('j') | Source/core/dom/Element.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698