Chromium Code Reviews
Help | Chromium Project | Sign in
(19)

Issue 9174019: Add skeleton plumbing for serial API. No functionality yet. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 2 months ago by miket_OOO
Modified:
3 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Add skeleton plumbing for serial API. No functionality yet. BUG=110241 TEST=added a small extension to test roundtrip. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -0 lines) Patch
A chrome/browser/extensions/api/serial/serial_api.h View 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/serial/serial_api.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/serial/serial_apitest.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/common_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/experimental.serial.json View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/serial/api/background.js View 1 chunk +20 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/serial/api/main.html View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/serial/api/manifest.json View 1 chunk +20 lines, -0 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 6 (0 generated)
miket_OOO
No hurry on this one.
3 years, 2 months ago (2012-01-13 23:49:19 UTC) #1
Mihai Parparita -not on Chrome
LGTM
3 years, 2 months ago (2012-01-18 16:43:50 UTC) #2
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/9174019/1
3 years, 2 months ago (2012-01-18 17:20:12 UTC) #3
I haz the power (commit-bot)
Try job failure for 9174019-1 (retry) on win_rel for steps "base_unittests, ui_tests" (clobber build). It's ...
3 years, 2 months ago (2012-01-18 19:33:37 UTC) #4
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miket@chromium.org/9174019/1
3 years, 2 months ago (2012-01-18 19:35:53 UTC) #5
I haz the power (commit-bot)
3 years, 2 months ago (2012-01-18 21:17:55 UTC) #6
Change committed as 118151
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d