IndexedDB: Test that Blink ack's blobs upon receipt.

IndexedDB: Test that Blink ack's blobs upon receipt.

Verified working by commenting out the call to ackReceivedBlobs in
Blink's IDBRequest::setBlobInfo() - test failed as expected.

BUG=457502
Committed: https://crrev.com/e07469c9746de915c9cd3ff3a99b4cbe01c484aa
Cr-Commit-Position: refs/heads/master@{#316339}

[cmumford, 2015-02-13 15:44:55]

cmumford@chromium.org changed reviewers:
+ jsbell@chromium.org

[jsbell, 2015-02-13 16:53:29]

lgtm with nits - thanks for pursuing this!

https://codereview.chromium.org/917353002/diff/20001/content/test/data/indexe...
File content/test/data/indexeddb/blob_did_ack.html (right):

https://codereview.chromium.org/917353002/diff/20001/content/test/data/indexe...
content/test/data/indexeddb/blob_did_ack.html:74: <div
id="status">Starting...<br></div>
Can you add a <p> with some text explaining that this test must be run with
--js-flags=... so that if someone tries to run it manually they'll understand
why it fails?

https://codereview.chromium.org/917353002/diff/20001/storage/browser/blob/blo...
File storage/browser/blob/blob_storage_context.h (right):

https://codereview.chromium.org/917353002/diff/20001/storage/browser/blob/blo...
storage/browser/blob/blob_storage_context.h:65: size_t num_blobs() const {
return blob_map_.size(); }
naming nit: Avoid use abbreviations like 'num'

Looking at other examples... how about blob_map_size() or blob_count() ?

Alternately, flip the semantics and make it Empty() ?

[cmumford, 2015-02-13 17:03:10]

New patchsets have been uploaded after l-g-t-m from jsbell@chromium.org

[cmumford, 2015-02-13 17:03:39]

https://codereview.chromium.org/917353002/diff/20001/content/test/data/indexe...
File content/test/data/indexeddb/blob_did_ack.html (right):

https://codereview.chromium.org/917353002/diff/20001/content/test/data/indexe...
content/test/data/indexeddb/blob_did_ack.html:74: <div
id="status">Starting...<br></div>
On 2015/02/13 16:53:29, jsbell wrote:
> Can you add a <p> with some text explaining that this test must be run with
> --js-flags=... so that if someone tries to run it manually they'll understand
> why it fails?

Done.

https://codereview.chromium.org/917353002/diff/20001/storage/browser/blob/blo...
File storage/browser/blob/blob_storage_context.h (right):

https://codereview.chromium.org/917353002/diff/20001/storage/browser/blob/blo...
storage/browser/blob/blob_storage_context.h:65: size_t num_blobs() const {
return blob_map_.size(); }
On 2015/02/13 16:53:29, jsbell wrote:
> naming nit: Avoid use abbreviations like 'num'
> 
> Looking at other examples... how about blob_map_size() or blob_count() ?
> 
> Alternately, flip the semantics and make it Empty() ?
> 

Done.

[jsbell, 2015-02-13 17:19:50]

lgtm - will need storage/ owner (michaeln?)

[cmumford, 2015-02-13 17:56:35]

cmumford@chromium.org changed reviewers:
+ michaeln@chromium.org

[cmumford, 2015-02-13 17:56:36]

+michaeln for storage.

[michaeln, 2015-02-13 21:03:21]

lgtm 2

[jsbell, 2015-02-13 21:16:37]

One last thing...

https://codereview.chromium.org/917353002/diff/40001/content/test/data/indexe...
File content/test/data/indexeddb/blob_did_ack.html (right):

https://codereview.chromium.org/917353002/diff/40001/content/test/data/indexe...
content/test/data/indexeddb/blob_did_ack.html:59: if (got_blob) {
Now that the test doesn't call blob.close(), I think the use of got_blob can be
removed.

[cmumford, 2015-02-13 22:54:25]

New patchsets have been uploaded after l-g-t-m from
jsbell@chromium.org,michaeln@chromium.org

[cmumford, 2015-02-13 23:06:47]

On 2015/02/13 21:16:37, jsbell wrote:
> One last thing...
> 
>
https://codereview.chromium.org/917353002/diff/40001/content/test/data/indexe...
> File content/test/data/indexeddb/blob_did_ack.html (right):
> 
>
https://codereview.chromium.org/917353002/diff/40001/content/test/data/indexe...
> content/test/data/indexeddb/blob_did_ack.html:59: if (got_blob) {
> Now that the test doesn't call blob.close(), I think the use of got_blob can
be
> removed.

done.

[cmumford, 2015-02-13 23:07:04]

The CQ bit was checked by cmumford@chromium.org

[jsbell, 2015-02-13 23:07:32]

still lgtm

[commit-bot: I haz the power, 2015-02-13 23:09:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/917353002/80001

[commit-bot: I haz the power, 2015-02-14 00:09:56]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-14 00:10:39]

Patchset 5 (id:??) landed as
https://crrev.com/e07469c9746de915c9cd3ff3a99b4cbe01c484aa
Cr-Commit-Position: refs/heads/master@{#316339}