content/browser/device_sensors/device_inertial_sensor_service.cc - Issue 917253002: [Android] Move the android Device Sensors API to the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/device_sensors/device_inertial_sensor_service.cc

Issue 917253002: [Android] Move the android Device Sensors API to the UI thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: simplify shutdown Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/device_sensors/data_fetcher_shared_memory_base.cc ('k') | content/browser/device_sensors/sensor_manager_android.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/device_sensors/device_inertial_sensor_service.cc

diff --git a/content/browser/device_sensors/device_inertial_sensor_service.cc b/content/browser/device_sensors/device_inertial_sensor_service.cc

index 840ce254bc1c0b284c97c931f77044e5b0bd6ff4..37952475532c921f47312f0f2b7139ce37b74222 100644

--- a/content/browser/device_sensors/device_inertial_sensor_service.cc

+++ b/content/browser/device_sensors/device_inertial_sensor_service.cc

@@ -94,7 +94,7 @@ DeviceInertialSensorService::GetSharedMemoryHandleForProcess(

void DeviceInertialSensorService::Shutdown() {

if (data_fetcher_) {

- data_fetcher_->StopFetchingAllDeviceData();

+ data_fetcher_->Shutdown();

data_fetcher_.reset();

}

is_shutdown_ = true;

@@ -103,7 +103,7 @@ void DeviceInertialSensorService::Shutdown() {

void DeviceInertialSensorService::SetDataFetcherForTesting(

DataFetcherSharedMemory* test_data_fetcher) {

if (data_fetcher_)

- data_fetcher_->StopFetchingAllDeviceData();

+ data_fetcher_->Shutdown();

data_fetcher_.reset(test_data_fetcher);

}