Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 917243002: Rename source_prereqs to inputs in the GN Build file. (Closed)

Created:
5 years, 10 months ago by tfarina
Modified:
5 years, 10 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev, brettw, Dirk Pranke, jochen (gone - plz use gerrit), Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Rename source_prereqs to inputs in the GN Build file. See more information in the gn-dev mailing list: https://groups.google.com/a/chromium.org/d/msg/gn-dev/j-P5hlvZ13M/4CSw2WworlkJ Also in https://chromium.googlesource.com/chromium/src/+/61a6fca4bca5438bf4338184c29fded55e5f240e BUG=374271 R=machenbach@chromium.org LOG=N Committed: https://crrev.com/29684963353e794f3216dfedef7984756535bd0e Cr-Commit-Position: refs/heads/master@{#26658}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
5 years, 10 months ago (2015-02-12 16:53:51 UTC) #1
tfarina
Michael, could you review this to me?
5 years, 10 months ago (2015-02-16 11:59:59 UTC) #3
Michael Achenbach
lgtm
5 years, 10 months ago (2015-02-16 12:03:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917243002/1
5 years, 10 months ago (2015-02-16 12:08:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-16 12:09:34 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-16 12:09:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29684963353e794f3216dfedef7984756535bd0e
Cr-Commit-Position: refs/heads/master@{#26658}

Powered by Google App Engine
This is Rietveld 408576698