Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 917223003: Add lock support for in process context provider. (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 10 months ago
Reviewers:
vmiura, piman
CC:
chromium-reviews, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add lock support for in process context provider. The context lost callback will be called on the thread that the command buffer was bound to, and with the lock held. BUG=454500 Committed: https://crrev.com/7dc2605574f04851cc6d2bc000a5a65e055d7e56 Cr-Commit-Position: refs/heads/master@{#316341}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/blink/webgraphicscontext3d_in_process_command_buffer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 1 4 chunks +11 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/common/gpu/context_provider_in_process.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/gpu/context_provider_in_process.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
jbauman
5 years, 10 months ago (2015-02-13 21:08:30 UTC) #2
piman
lgtm
5 years, 10 months ago (2015-02-13 22:02:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917223003/20001
5 years, 10 months ago (2015-02-13 22:13:50 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/25111)
5 years, 10 months ago (2015-02-13 23:14:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917223003/20001
5 years, 10 months ago (2015-02-13 23:22:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-14 00:23:02 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-14 00:23:34 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7dc2605574f04851cc6d2bc000a5a65e055d7e56
Cr-Commit-Position: refs/heads/master@{#316341}

Powered by Google App Engine
This is Rietveld 408576698