The network_moved check in DoHandshakeLoop should only apply to

The network_moved check in DoHandshakeLoop should only apply to
STATE_HANDSHAKE.

After transport I/O completes synchronously, stay in the handshake
loop only if the next state is STATE_HANDSHAKE, which is the only
state that requires transport I/O to make progress.  If the next state
is any other state, we should ignore network_moved when determing if we
should stay in the handshake loop.

This changelist is the synchronous completion version of
http://codereview.chromium.org/660131, which dealt with this bug
when transport I/O completes asynchronously.

R=agl@chromium.org
BUG=109706
TEST=Run a Chrome debug build with --enable-origin-bound-certs and
connect to a Google server such as gmail over HTTPS.  Should not hit
a DCHECK failure in net_log.cc.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117578

[wtc, 2012-01-11 02:54:03]

agl: this CL causes the SSLClientSocketTest.Connect unit test
to hang.  I will let you know when I fix the problem.

[wtc, 2012-01-11 04:19:55]

agl: please review Patch Set 2.

http://codereview.chromium.org/9172005/diff/1/net/socket/ssl_client_socket_ns...
File net/socket/ssl_client_socket_nss.cc (right):

http://codereview.chromium.org/9172005/diff/1/net/socket/ssl_client_socket_ns...
net/socket/ssl_client_socket_nss.cc:1304: continue;

After a lot of debugging, I finally figured out what was wrong.

In a do-while loop, the 'continue' statement continues to
the bottom of the loop (to evaluate the loop condition)
rather than the top of the loop (to start the next iteration).

[agl, 2012-01-11 18:02:27]

lgtm

[commit-bot: I haz the power, 2012-01-12 23:38:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wtc@chromium.org/9172005/9001

[commit-bot: I haz the power, 2012-01-13 02:14:00]

Change committed as 117578