Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: src/compiler.cc

Issue 917193002: Fix GCMole after b79b985988fd (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 46373ff7ead94f9ae1b2a726d0bc4e19be6bfbb7..c1d62d0a2d64169bea803d5b8a5e10fdeb7df06d 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -215,7 +215,7 @@ void CompilationInfo::CommitDependencies(Handle<Code> code) {
if (!has_dependencies) return;
AllowDeferredHandleDereference get_object_wrapper;
- Handle<WeakCell> cell = Code::WeakCellFor(code);
+ WeakCell* cell = *Code::WeakCellFor(code);
for (int i = 0; i < DependentCode::kGroupCount; i++) {
ZoneList<Handle<HeapObject> >* group_objects = dependencies_[i];
if (group_objects == NULL) continue;
@@ -223,9 +223,10 @@ void CompilationInfo::CommitDependencies(Handle<Code> code) {
for (int j = 0; j < group_objects->length(); j++) {
DependentCode::DependencyGroup group =
static_cast<DependentCode::DependencyGroup>(i);
+ Foreign* info = *object_wrapper();
DependentCode* dependent_code =
DependentCode::ForObject(group_objects->at(j), group);
- dependent_code->UpdateToFinishedCode(group, *object_wrapper(), *cell);
+ dependent_code->UpdateToFinishedCode(group, info, cell);
}
dependencies_[i] = NULL; // Zone-allocated, no need to delete.
}
@@ -241,9 +242,10 @@ void CompilationInfo::RollbackDependencies() {
for (int j = 0; j < group_objects->length(); j++) {
DependentCode::DependencyGroup group =
static_cast<DependentCode::DependencyGroup>(i);
+ Foreign* info = *object_wrapper();
DependentCode* dependent_code =
DependentCode::ForObject(group_objects->at(j), group);
- dependent_code->RemoveCompilationInfo(group, *object_wrapper());
+ dependent_code->RemoveCompilationInfo(group, info);
}
dependencies_[i] = NULL; // Zone-allocated, no need to delete.
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698