Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 917193002: Fix GCMole after b79b985988fd (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix GCMole after b79b985988fd NOTREECHECKS=true BUG= TBR=verwaest@chromium.org

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/compiler.cc View 1 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
ulan
PTAL
5 years, 10 months ago (2015-02-12 14:47:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917193002/1
5 years, 10 months ago (2015-02-12 14:52:08 UTC) #4
Toon Verwaest
lgtm
5 years, 10 months ago (2015-02-12 14:59:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/2935)
5 years, 10 months ago (2015-02-12 15:08:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917193002/20001
5 years, 10 months ago (2015-02-12 15:19:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917193002/20001
5 years, 10 months ago (2015-02-12 16:00:09 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-12 16:00:37 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 16:01:04 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1291400fbb12fee925201db9360d2ab9568cb57f
Cr-Commit-Position: refs/heads/master@{#26622}

Powered by Google App Engine
This is Rietveld 408576698