Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 917083002: Sort GYP files under base using tools/sort_sources.py (Closed)

Created:
5 years, 10 months ago by satorux1
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sort GYP files under base using tools/sort_sources.py For tools/sort_sources.py to be useful, existing GYP files should be sorted. BUG=456014 TEST=everything should build as before Committed: https://crrev.com/357fcdaa1150bc7629984d8af02a1ae670c26e5b Cr-Commit-Position: refs/heads/master@{#316164}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Patch Set 3 : fix the bug #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -61 lines) Patch
M base/base.gyp View 9 chunks +10 lines, -10 lines 0 comments Download
M base/base.gypi View 1 2 20 chunks +41 lines, -41 lines 1 comment Download
M tools/sort_sources.py View 1 2 2 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
satorux1
5 years, 10 months ago (2015-02-12 06:58:44 UTC) #2
Lei Zhang
There's a case that requires manual intervention, otherwise lgtm https://codereview.chromium.org/917083002/diff/1/base/base.gypi File base/base.gypi (right): https://codereview.chromium.org/917083002/diff/1/base/base.gypi#newcode151 base/base.gypi:151: ...
5 years, 10 months ago (2015-02-12 07:07:09 UTC) #3
satorux1
https://codereview.chromium.org/917083002/diff/1/base/base.gypi File base/base.gypi (right): https://codereview.chromium.org/917083002/diff/1/base/base.gypi#newcode151 base/base.gypi:151: 'third_party/dmg_fp/dmg_fp.h', On 2015/02/12 07:07:09, Lei Zhang wrote: > The ...
5 years, 10 months ago (2015-02-13 00:50:55 UTC) #4
satorux1
PTAL https://codereview.chromium.org/917083002/diff/40001/base/base.gypi File base/base.gypi (right): https://codereview.chromium.org/917083002/diff/40001/base/base.gypi#newcode602 base/base.gypi:602: 'third_party/xdg_mime/xdgmime.h', fixed!
5 years, 10 months ago (2015-02-13 02:27:53 UTC) #6
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-13 02:35:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917083002/40001
5 years, 10 months ago (2015-02-13 03:32:12 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-13 04:37:10 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-13 04:38:05 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/357fcdaa1150bc7629984d8af02a1ae670c26e5b
Cr-Commit-Position: refs/heads/master@{#316164}

Powered by Google App Engine
This is Rietveld 408576698