Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 917063004: Convert Obj-C 2.0 syntax to Obj-C 1.0 (Closed)

Created:
5 years, 10 months ago by dvh
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Obj-C 2.0 allows to declare ivars in @implementation section. Obj-C 1.0 only allows to declare ivars in @interface section. Committed: https://crrev.com/8c700e2511ed9c93b7245a525238086b88c2ee34 Cr-Commit-Position: refs/heads/master@{#316236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M device/bluetooth/bluetooth_low_energy_discovery_manager_mac.mm View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dvh
5 years, 10 months ago (2015-02-12 18:43:07 UTC) #2
Michael Achenbach
lgtm (rubber-stamp)
5 years, 10 months ago (2015-02-13 09:14:53 UTC) #4
armansito
lgtm
5 years, 10 months ago (2015-02-13 16:16:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917063004/1
5 years, 10 months ago (2015-02-13 17:07:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-13 17:38:55 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8c700e2511ed9c93b7245a525238086b88c2ee34 Cr-Commit-Position: refs/heads/master@{#316236}
5 years, 10 months ago (2015-02-13 17:39:27 UTC) #9
Michael Achenbach
5 years, 10 months ago (2015-02-13 20:40:40 UTC) #10
Message was sent while issue was closed.
This helped thanks.

Powered by Google App Engine
This is Rietveld 408576698