Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2387)

Unified Diff: chrome/browser/resources/chromeos/network_ui/network_ui.js

Issue 917053002: Add Source property to networkingPrivate.getState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase with separated test expectations Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/networking_private/chromeos/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/network_ui/network_ui.js
diff --git a/chrome/browser/resources/chromeos/network_ui/network_ui.js b/chrome/browser/resources/chromeos/network_ui/network_ui.js
index d03b71f052d0acd737f456a6f03ac33de89d6001..970d6b772fa921f7abad20b1bb1ce1958edeb645 100644
--- a/chrome/browser/resources/chromeos/network_ui/network_ui.js
+++ b/chrome/browser/resources/chromeos/network_ui/network_ui.js
@@ -32,7 +32,7 @@ var NetworkUI = (function() {
'Type',
'profile_path',
'visible',
- 'onc_source'
+ 'Source'
];
/**
@@ -143,6 +143,16 @@ var NetworkUI = (function() {
};
/**
+ * Returns a valid HTMLElement id from |guid|.
+ *
+ * @param {string} guid A GUID which may start with a digit
+ * @return {string} A valid HTMLElement id.
+ */
+ var idFromGuid = function(guid) {
+ return '_' + guid.replace(/[{}]/g, '');
+ };
+
+ /**
* This callback function is triggered when visible networks are received.
*
* @param {Array} states A list of network state information for each
@@ -198,7 +208,7 @@ var NetworkUI = (function() {
emptyCell.style.border = 'none';
expandedRow.appendChild(emptyCell);
var detailCell = document.createElement('td');
- detailCell.id = guid;
+ detailCell.id = idFromGuid(guid);
detailCell.className = 'state-table-expanded-cell';
detailCell.colSpan = baseRow.childNodes.length - 1;
expandedRow.appendChild(detailCell);
@@ -236,7 +246,7 @@ var NetworkUI = (function() {
return;
}
- var detailCell = document.querySelector('td#' + guid);
+ var detailCell = document.querySelector('td#' + idFromGuid(guid));
if (!detailCell) {
console.error('No cell for GUID: ' + guid);
return;
« no previous file with comments | « no previous file | chrome/test/data/extensions/api_test/networking_private/chromeos/test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698