Add Source property to networkingPrivate.getState

chrome/browser/resources/chromeos/network_ui/network_ui.js

Index: chrome/browser/resources/chromeos/network_ui/network_ui.js
diff --git a/chrome/browser/resources/chromeos/network_ui/network_ui.js b/chrome/browser/resources/chromeos/network_ui/network_ui.js
index d03b71f052d0acd737f456a6f03ac33de89d6001..017307fb4969a6860b69dea140644a5304543802 100644
--- a/chrome/browser/resources/chromeos/network_ui/network_ui.js
+++ b/chrome/browser/resources/chromeos/network_ui/network_ui.js
@@ -32,7 +32,7 @@ var NetworkUI = (function() {
     'Type',
     'profile_path',
     'visible',
-    'onc_source'
+    'Source'
   ];
 
   /**
@@ -143,6 +143,18 @@ var NetworkUI = (function() {
   };
 
   /**
+   * Returns a valid HTMLElement id from |guid|.
+   *
+   * @param {string} guid A GUID which may start with a digit
+   * @return {string} A valid HTMLElement id.
+   */
+  var idFromGuid = function(guid) {
+    if (guid.substring(0, 1) == '{')

[pneubeck (no reviews), 2015/02/17 18:00:49]

can't you just remove all '{' and '}' or replace them by a valid character?
seems weird to handle such a specific case.

[stevenjb, 2015/02/17 18:23:30]

Sure, that works also.

+      guid = guid.substring(1, guid.length - 2);
+    return '_' + guid;
+  };
+
+  /**
    * This callback function is triggered when visible networks are received.
    *
    * @param {Array} states A list of network state information for each
@@ -198,7 +210,7 @@ var NetworkUI = (function() {
     emptyCell.style.border = 'none';
     expandedRow.appendChild(emptyCell);
     var detailCell = document.createElement('td');
-    detailCell.id = guid;
+    detailCell.id = idFromGuid(guid);
     detailCell.className = 'state-table-expanded-cell';
     detailCell.colSpan = baseRow.childNodes.length - 1;
     expandedRow.appendChild(detailCell);
@@ -236,7 +248,7 @@ var NetworkUI = (function() {
       return;
     }
 
-    var detailCell = document.querySelector('td#' + guid);
+    var detailCell = document.querySelector('td#' + idFromGuid(guid));
     if (!detailCell) {
       console.error('No cell for GUID: ' + guid);
       return;