content/browser/frame_host/navigation_controller_impl.cc - Issue 917043004: Mark error pages as such on Ctrl-Shift-T reload.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_controller_impl.cc

Issue 917043004: Mark error pages as such on Ctrl-Shift-T reload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_controller_impl.cc

diff --git a/content/browser/frame_host/navigation_controller_impl.cc b/content/browser/frame_host/navigation_controller_impl.cc

index 979b26c1dc5603b12adb1edc1907ea5a08cc41aa..716db64baf6d28c22154c53eb0d08999aaff675e 100644

--- a/content/browser/frame_host/navigation_controller_impl.cc

+++ b/content/browser/frame_host/navigation_controller_impl.cc

@@ -1124,6 +1124,8 @@ void NavigationControllerImpl::RendererDidNavigateToExistingPage(

NavigationEntryImpl* entry = entries_[entry_index].get();

// The URL may have changed due to redirects.

+ if (params.url_is_unreachable)

+ entry->set_page_type(PAGE_TYPE_ERROR);

entry->SetURL(params.url);

entry->SetReferrer(params.referrer);

if (entry->update_virtual_url_with_url())