Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 917043003: Make MediaControls::m_wasLastEventTouch a local variable (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
william.xie1, fs
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make MediaControls::m_wasLastEventTouch a local variable Made possible by "Ensure media control goes to transparent(hide) after seek by touch": https://codereview.chromium.org/892963003 BUG=454304 R=william.xie@intel.com, fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190039

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M Source/core/html/shadow/MediaControls.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
PTAL
5 years, 10 months ago (2015-02-12 04:20:46 UTC) #2
fs
lgtm
5 years, 10 months ago (2015-02-12 09:46:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917043003/1
5 years, 10 months ago (2015-02-12 10:04:54 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 11:19:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190039

Powered by Google App Engine
This is Rietveld 408576698