Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1999)

Issue 917023003: Revert of Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows. (Closed)

Created:
5 years, 10 months ago by Ken Russell (switch to Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@free-list
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows. (patchset #1 id:1 of https://codereview.chromium.org/793443003/) Reason for revert: Caused random crashes on GPU bots with this assertion failure: WebglConformance.conformance_ogles_GL_log_log_001_to_008: Error installing extension 'v8/gc'. [3060:3996:0218/193241:FATAL:discardable_shared_memory_heap.cc(205)] Check failed: spans_.find(span->start_ + span->length_ - 1) != spans_.end(). Original issue's description: > Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows. > > This makes SHMEM implementation of discardable memory preferred > over EMULATED implementation. This effectively makes SHMEM the > implementation used by default on Linux, CrOS and Windows. > > SHMEM implementation of discardable memory gives the browser > process control over the total amount of discardable memory used > and allows us to enforce a global limit of 512MB across all > renderers. > > BUG=429415, 429416 > > Committed: https://crrev.com/2f7a8e80b83aa581aa6de86117a692093d16c217 > Cr-Commit-Position: refs/heads/master@{#316977} TBR=avi@chromium.org,danakj@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=429415, 429416 Committed: https://crrev.com/e8360108c83458621520fc41aa00359bc90955a5 Cr-Commit-Position: refs/heads/master@{#316997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M base/memory/discardable_memory_android.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/discardable_memory_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ken Russell (switch to Gerrit)
Created Revert of Re-land: base: Enable browser-wide discardable memory on Linux, CrOS and Windows.
5 years, 10 months ago (2015-02-19 06:19:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/917023003/1
5 years, 10 months ago (2015-02-19 06:20:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 06:21:33 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 06:22:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8360108c83458621520fc41aa00359bc90955a5
Cr-Commit-Position: refs/heads/master@{#316997}

Powered by Google App Engine
This is Rietveld 408576698